Fixes all bugs. #78
Merged
Fixes all bugs. #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Poggit-CI is enabled for this repo by @michoudll Visit the Poggit-CI page for this repo at https://poggit.pmmp.io/ci/Deepslate/MapImageEngine
TheNewHEROBRINEX
suggested changes
Jul 3, 2021
| $this->data->buffer[$pos++] = chr($color >> 24 & 0xff); | ||
| $this->data->buffer[$pos++] = chr($color >> 16 & 0xff); | ||
| $this->data->buffer[$pos++] = chr($color >> 8 & 0xff); | ||
| $this->data->buffer[$pos] = chr($color & 0xff); |
There was a problem hiding this comment.
Here you removed two spaces before the = sign that were present to make the last chr call aligned with the previous ones.
Author
There was a problem hiding this comment.
i just used code styles from pmmp. does this affect the final work of the plugin?
There was a problem hiding this comment.
No but you shouldn't change the formatting of the code for no reason at all
Author
There was a problem hiding this comment.
i changed the formatting back, the author hasn't been here for a long time, so i think nothing will change.
Special for @TheNewHEROBRINEX.
TheNewHEROBRINEX
suggested changes
Jul 5, 2021
| $this->data->buffer[$pos++] = chr($color & 0xff); | ||
| $this->data->buffer[$pos++] = chr($color >> 8 & 0xff); | ||
| $this->data->buffer[$pos++] = chr($color >> 16 & 0xff); | ||
| $this->data->buffer[$pos] = chr($color >> 24 & 0xff); |
There was a problem hiding this comment.
Also here (I didn't notice before)
TheNewHEROBRINEX
approved these changes
Jul 5, 2021
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently fully working. Tested on PocketMine-MP 3.21.0