Fac 1317/fix/file upload #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses file upload issues across different environments by replacing the usage of the form-data package with the isomorphic formdata-node package and converting NodeJS.ReadableStreams to Buffers to ensure compatibility with fetch.
- Removed the form-data module from the external dependencies in the Vite configuration.
- Refactored wrapper and organizations code to use FormData uniformly, along with adding a utility (streamToBuffer) for Node stream conversion.
- Updated the CHANGELOG to document these file upload improvements.
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| vite.config.ts | Removed 'form-data' from external dependencies to align with the new isomorphic formdata-node usage. |
| src/wrapper.ts | Refactored FormData usage and header handling to support both Node and browser environments. |
| src/utils/streamToBuffer.ts | Added a utility function to convert NodeJS.ReadableStream objects to Buffers. |
| src/resources/organizations.ts | Updated file upload methods to support Buffer and ReadableStream inputs using the prepareFile utility. |
| CHANGELOG.md | Documented the updated file upload methods and related fixes. |
Files not reviewed (1)
- package.json: Language not supported
Comments suppressed due to low confidence (1)
src/wrapper.ts:99
- By removing the custom header logic that incorporated formData boundary details in Node environments, there is a risk that the request may lack the necessary 'Content-Type' boundary parameters. Consider verifying if the new header logic works correctly with formdata-node on the server side.
headers: { ...defaultHeaders, ...(formData ? {} : { 'Content-Type': 'application/json' }), }
raul-facturapi
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
formdata-nodepackageNodeJS.ReadableStreams toBufferto make it compatible withfetch