Agregar propiedad "Status" a objeto de error #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
javorosas
commented
Dec 10, 2025
javorosas
commented
- Se agrega propiedad "Status" al objeto de error
- Se centraliza el manejo de errores en método compartido en BaseWrapper
- Se eliminan "using"s innecesarios
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves error handling in the Facturapi .NET SDK by adding a "Status" property to the FacturapiException class and centralizing error handling logic in the BaseWrapper class through a new ThrowIfErrorAsync method. This refactoring eliminates code duplication across all wrapper classes.
- Adds a
Statusproperty toFacturapiExceptionto expose HTTP status codes from API errors - Introduces centralized error handling through
BaseWrapper.ThrowIfErrorAsyncandCreateExceptionmethods - Removes duplicated error handling code from all wrapper classes, replacing it with calls to the shared method
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| FacturAPIException.cs | Adds Status property and updates constructor to accept optional status parameter |
| Wrappers/BaseWrapper.cs | Introduces CreateException and ThrowIfErrorAsync methods to centralize error handling logic |
| Wrappers/WebhookWrapper.cs | Replaces inline error handling with ThrowIfErrorAsync calls; removes unused imports |
| Wrappers/ToolWrapper.cs | Replaces inline error handling with ThrowIfErrorAsync calls; removes unused imports |
| Wrappers/RetentionWrapper.cs | Replaces inline error handling with ThrowIfErrorAsync calls; removes unused imports |
| Wrappers/ReceiptWrapper.cs | Replaces inline error handling with ThrowIfErrorAsync calls; removes unused imports |
| Wrappers/ProductWrapper.cs | Replaces inline error handling with ThrowIfErrorAsync calls; removes unused imports |
| Wrappers/OrganizationWrapper.cs | Replaces inline error handling with ThrowIfErrorAsync calls; removes unused imports; fixes indentation |
| Wrappers/InvoiceWrapper.cs | Replaces inline error handling with ThrowIfErrorAsync calls; removes unused imports |
| Wrappers/CustomerWrapper.cs | Replaces inline error handling with ThrowIfErrorAsync calls; removes unused imports; fixes indentation |
| Wrappers/CatalogWrapper.cs | Replaces inline error handling with ThrowIfErrorAsync calls; removes unused imports |
Comments suppressed due to low confidence (1)
Wrappers/BaseWrapper.cs:43
- Poor error handling: empty catch block.
catch (JsonException)
{
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…wing - Updated `FacturapiException` to include an optional status code. - Introduced `ThrowIfErrorAsync` method in `BaseWrapper` to handle HTTP response errors consistently across all wrappers. - Removed redundant error handling code from `CatalogWrapper`, `CustomerWrapper`, `InvoiceWrapper`, `OrganizationWrapper`, `ProductWrapper`, `ReceiptWrapper`, `RetentionWrapper`, `ToolWrapper`, and `WebhookWrapper`. - Ensured all wrappers now utilize the new error handling method for improved maintainability and readability.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…archCatalogAsync for error handling and response parsing
javorosas
force-pushed
the
FAC-1703/feat/add-status-field-on-error-object
branch
from
fcee372 to
aa21682
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.