Add PreviewPdfAsync methods for invoice PDF preview #37
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new PreviewPdfAsync method to enable invoice PDF preview functionality before stamping. This feature allows users to preview how an invoice PDF will look without actually creating the invoice.
Key changes:
- Added
PreviewPdfAsyncmethod toInvoiceWrapperclass - Added corresponding route helper in
InvoiceRouter - Updated version to 4.10.0
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| facturapi-net.csproj | Version bump to 4.10.0 |
| Wrappers/InvoiceWrapper.cs | Added PreviewPdfAsync method implementation |
| Router/InvoiceRouter.cs | Added PreviewPdf route helper method |
| CHANGELOG.md | Added changelog entry for new feature |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| var response = await client.GetAsync(Router.PreviewPdf(query)); | ||
| if (!response.IsSuccessStatusCode) | ||
| { | ||
| var resultString = await response.Content.ReadAsStringAsync(); | ||
| var error = JsonConvert.DeserializeObject<JObject>(resultString, this.jsonSettings); | ||
| throw new FacturapiException(error["message"].ToString()); | ||
| } | ||
| var stream = await response.Content.ReadAsStreamAsync(); | ||
| return stream; |
There was a problem hiding this comment.
The method doesn't dispose of the HTTP response, which can lead to resource leaks. The response should be wrapped in a using statement or the stream should be copied to avoid keeping the HTTP connection open.
| var response = await client.GetAsync(Router.PreviewPdf(query)); | |
| if (!response.IsSuccessStatusCode) | |
| { | |
| var resultString = await response.Content.ReadAsStringAsync(); | |
| var error = JsonConvert.DeserializeObject<JObject>(resultString, this.jsonSettings); | |
| throw new FacturapiException(error["message"].ToString()); | |
| } | |
| var stream = await response.Content.ReadAsStreamAsync(); | |
| return stream; | |
| using (var response = await client.GetAsync(Router.PreviewPdf(query))) | |
| { | |
| if (!response.IsSuccessStatusCode) | |
| { | |
| var resultString = await response.Content.ReadAsStringAsync(); | |
| var error = JsonConvert.DeserializeObject<JObject>(resultString, this.jsonSettings); | |
| throw new FacturapiException(error["message"].ToString()); | |
| } | |
| var responseStream = await response.Content.ReadAsStreamAsync(); | |
| var memoryStream = new MemoryStream(); | |
| await responseStream.CopyToAsync(memoryStream); | |
| memoryStream.Position = 0; | |
| return memoryStream; | |
| } |
| { | ||
| var resultString = await response.Content.ReadAsStringAsync(); | ||
| var error = JsonConvert.DeserializeObject<JObject>(resultString, this.jsonSettings); | ||
| throw new FacturapiException(error["message"].ToString()); |
There was a problem hiding this comment.
Potential null reference exception if the response JSON doesn't contain a 'message' field. The code should check if error['message'] exists before calling ToString().
No description provided.