Merge pull request #36 from FacturAPI/fix/send-by-email-signature

javorosas · web-flow · commit 8dbfc14ce201 · 2025-07-22T12:48:31.000+02:00
Fix/send by email signature
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,17 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [4.9.1] - 2025-07-21
+
+### Fixed
+
+- Fix `Invoices.SendByEmailAsync`, `Receipts.SendByEmailAsync`, `Retentions.SendByEmailAsync` method and mark the `data` parameter as optional.
+
+### Added
+
+- Add `AddOns` property to `Organization` model to support Facturapi add-ons.
+- Add missing properties to `Organization.Customization.PdfExtra` model: `AddressCodes`, `RoundUnitPrice`, `TaxBreakdown`, `IepsBreakdown`, `RenderCartaPorte`, and `RepeatSignature`.
+
 ## [4.9.0] - 2025-06-16
 
 ### Added
diff --git a/Models/Organization.cs b/Models/Organization.cs
@@ -14,5 +14,6 @@ public class Organization
         public SelfInvoiceSettings SelfInvoice { get; set; }
         public Certificate Certificate { get; set; }
         public List<LiveApiKey> ApiKeys { get; set; }
+        public List<string> AddOns { get; set; }
     }
 }
diff --git a/Models/PdfExtra.cs b/Models/PdfExtra.cs
@@ -3,6 +3,12 @@ namespace Facturapi
     public class PdfExtra
     {
         public bool Codes { get; set; }
+        public bool AddressCodes { get; set; }
         public bool ProductKey { get; set; }
+        public bool RoundUnitPrice { get; set; }
+        public bool TaxBreakdown { get; set; }
+        public bool IepsBreakdown { get; set; }
+        public bool RenderCartaPorte { get; set; }
+        public bool RepeatSignature { get; set; }
     }
 }
diff --git a/Wrappers/InvoiceWrapper.cs b/Wrappers/InvoiceWrapper.cs
@@ -70,7 +70,7 @@ public async Task<Invoice> CancelAsync(string id, Dictionary<string, object> que
             return invoice;
         }
 
-        public async Task SendByEmailAsync(string id, Dictionary<string, object> data)
+        public async Task SendByEmailAsync(string id, Dictionary<string, object> data = null)
         {
             var response = await client.PostAsync(Router.SendByEmail(id), new StringContent(JsonConvert.SerializeObject(data), Encoding.UTF8, "application/json"));
             if (!response.IsSuccessStatusCode)
diff --git a/Wrappers/ReceiptWrapper.cs b/Wrappers/ReceiptWrapper.cs
@@ -90,7 +90,7 @@ public async Task CreateGlobalInvoiceAsync(string id, Dictionary<string, object>
             }
         }
 
-        public async Task SendByEmailAsync(string id, Dictionary<string, object> data)
+        public async Task SendByEmailAsync(string id, Dictionary<string, object> data = null)
         {
             var response = await client.PostAsync(Router.SendReceiptByEmail(id), new StringContent(JsonConvert.SerializeObject(data), Encoding.UTF8, "application/json"));
             if (!response.IsSuccessStatusCode)
diff --git a/Wrappers/RetentionWrapper.cs b/Wrappers/RetentionWrapper.cs
@@ -70,7 +70,7 @@ public async Task<Invoice> CancelAsync(string id)
             return customer;
         }
 
-        public async Task SendByEmailAsync(string id, Dictionary<string, object> data)
+        public async Task SendByEmailAsync(string id, Dictionary<string, object> data = null)
         {
             var response = await client.PostAsync(Router.SendRetentionByEmail(id), new StringContent(JsonConvert.SerializeObject(data), Encoding.UTF8, "application/json"));
             if (!response.IsSuccessStatusCode)
diff --git a/facturapi-net.csproj b/facturapi-net.csproj
@@ -11,7 +11,7 @@
       API Keys creando una cuenta gratuita en https://www.facturapi.io</Summary>
     <PackageTags>factura factura-electronica cfdi facturapi mexico conekta</PackageTags>
     <Title>Facturapi</Title>
-    <Version>4.9.0</Version>
+    <Version>4.9.1</Version>
     <PackageVersion>$(Version)</PackageVersion>
     <Owners>Facturapi</Owners>
     <ApplicationIcon>facturapi.ico</ApplicationIcon>

Original file line number	Diff line number	Diff line change
`@@ -14,5 +14,6 @@ public class Organization`
`14`	`14`	`public SelfInvoiceSettings SelfInvoice { get; set; }`
`15`	`15`	`public Certificate Certificate { get; set; }`
`16`	`16`	`public List<LiveApiKey> ApiKeys { get; set; }`
	`17`	`+ public List<string> AddOns { get; set; }`
`17`	`18`	`}`
`18`	`19`	`}`
Original file line number	Diff line number	Diff line change
`@@ -3,6 +3,12 @@ namespace Facturapi`
`3`	`3`	`public class PdfExtra`
`4`	`4`	`{`
`5`	`5`	`public bool Codes { get; set; }`
	`6`	`+ public bool AddressCodes { get; set; }`
`6`	`7`	`public bool ProductKey { get; set; }`
	`8`	`+ public bool RoundUnitPrice { get; set; }`
	`9`	`+ public bool TaxBreakdown { get; set; }`
	`10`	`+ public bool IepsBreakdown { get; set; }`
	`11`	`+ public bool RenderCartaPorte { get; set; }`
	`12`	`+ public bool RepeatSignature { get; set; }`
`7`	`13`	`}`
`8`	`14`	`}`
Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ public async Task<Invoice> CancelAsync(string id, Dictionary<string, object> que`
`70`	`70`	`return invoice;`
`71`	`71`	`}`
`72`	`72`
`73`		`- public async Task SendByEmailAsync(string id, Dictionary<string, object> data)`
	`73`	`+ public async Task SendByEmailAsync(string id, Dictionary<string, object> data = null)`
`74`	`74`	`{`
`75`	`75`	`var response = await client.PostAsync(Router.SendByEmail(id), new StringContent(JsonConvert.SerializeObject(data), Encoding.UTF8, "application/json"));`
`76`	`76`	`if (!response.IsSuccessStatusCode)`
Original file line number	Diff line number	Diff line change
`@@ -90,7 +90,7 @@ public async Task CreateGlobalInvoiceAsync(string id, Dictionary<string, object>`
`90`	`90`	`}`
`91`	`91`	`}`
`92`	`92`
`93`		`- public async Task SendByEmailAsync(string id, Dictionary<string, object> data)`
	`93`	`+ public async Task SendByEmailAsync(string id, Dictionary<string, object> data = null)`
`94`	`94`	`{`
`95`	`95`	`var response = await client.PostAsync(Router.SendReceiptByEmail(id), new StringContent(JsonConvert.SerializeObject(data), Encoding.UTF8, "application/json"));`
`96`	`96`	`if (!response.IsSuccessStatusCode)`