Enhance resource cleanup by marking FacturapiClient as sealed and implementing disposal pattern

javorosas · javorosas · commit 358340a335e8 · 2025-12-11T12:00:19.000-07:00
diff --git a/FacturapiClient.cs b/FacturapiClient.cs
@@ -6,7 +6,7 @@
 
 namespace Facturapi
 {
-    public class FacturapiClient : IFacturapiClient
+    public sealed class FacturapiClient : IFacturapiClient
     {
         public CustomerWrapper Customer { get; private set; }
         public ProductWrapper Product { get; private set; }
@@ -19,6 +19,7 @@ public class FacturapiClient : IFacturapiClient
         public ToolWrapper Tool { get; private set; }
         public WebhookWrapper Webhook { get; private set; }
         private readonly HttpClient httpClient;
+        private bool disposed;
 
         public FacturapiClient(string apiKey, string apiVersion = "v2")
         {
@@ -43,7 +44,14 @@ public FacturapiClient(string apiKey, string apiVersion = "v2")
 
         public void Dispose()
         {
+            if (this.disposed)
+            {
+                return;
+            }
+
             this.httpClient?.Dispose();
+            this.disposed = true;
+            GC.SuppressFinalize(this);
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`
`7`	`7`	`namespace Facturapi`
`8`	`8`	`{`
`9`		`- public class FacturapiClient : IFacturapiClient`
	`9`	`+ public sealed class FacturapiClient : IFacturapiClient`
`10`	`10`	`{`
`11`	`11`	`public CustomerWrapper Customer { get; private set; }`
`12`	`12`	`public ProductWrapper Product { get; private set; }`
`@@ -19,6 +19,7 @@ public class FacturapiClient : IFacturapiClient`
`19`	`19`	`public ToolWrapper Tool { get; private set; }`
`20`	`20`	`public WebhookWrapper Webhook { get; private set; }`
`21`	`21`	`private readonly HttpClient httpClient;`
	`22`	`+ private bool disposed;`
`22`	`23`
`23`	`24`	`public FacturapiClient(string apiKey, string apiVersion = "v2")`
`24`	`25`	`{`
`@@ -43,7 +44,14 @@ public FacturapiClient(string apiKey, string apiVersion = "v2")`
`43`	`44`
`44`	`45`	`public void Dispose()`
`45`	`46`	`{`
	`47`	`+ if (this.disposed)`
	`48`	`+ {`
	`49`	`+ return;`
	`50`	`+ }`
	`51`	`+`
`46`	`52`	`this.httpClient?.Dispose();`
	`53`	`+ this.disposed = true;`
	`54`	`+ GC.SuppressFinalize(this);`
`47`	`55`	`}`
`48`	`56`	`}`
`49`	`57`	`}`