Skip to content

Conversation

@its-miroma
Copy link
Member

@its-miroma its-miroma commented Feb 26, 2025

you may want to fix on Crowdin #90 as well

  • sort usernames
  • fix some duplicates
  • add GitHub usernames where available
  • use GitHub API to get the preferred capitalization

this combined with #280 allows for crediting as many people as possible.
I most probably missed someone, for which I am deeply sorry, if so remind please us in #docs on Discord

@its-miroma its-miroma added correction Something isn't right on a page todo:verify This needs to be reviewed labels Feb 26, 2025
@its-miroma its-miroma requested a review from a team as a code owner February 26, 2025 22:48
@netlify
Copy link

netlify bot commented Feb 26, 2025

Deploy Preview for nimble-elf-d9d491 ready!

Name Link
🔨 Latest commit 31f3b18
🔍 Latest deploy log https://app.netlify.com/sites/nimble-elf-d9d491/deploys/67d19ca3cfd2d00007b69635
😎 Deploy Preview https://deploy-preview-292--nimble-elf-d9d491.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@its-miroma its-miroma changed the title add missing author information Add missing author information Feb 26, 2025
IMB11
IMB11 previously requested changes Mar 5, 2025
Copy link
Member

@IMB11 IMB11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ended up stopping checking, because the majority of the pages you've added authors to are not from the fabric wiki and are in fact original content - please can you properly double check whether content is docs OC or OC from the old moddedmc.wiki reused for the docs or from the fabric wiki...

@its-miroma its-miroma changed the title Add missing author information Correct author information Mar 6, 2025
@its-miroma its-miroma requested a review from IMB11 March 6, 2025 12:33
@its-miroma its-miroma force-pushed the authors branch 3 times, most recently from 8395a1b to a1335f4 Compare March 12, 2025 09:54
@its-miroma its-miroma added stage:ready and removed todo:verify This needs to be reviewed labels Mar 12, 2025
modmuss50
modmuss50 previously approved these changes Mar 12, 2025
@its-miroma its-miroma dismissed IMB11’s stale review March 12, 2025 14:09

the pr no longer adds any new authors

@IMB11 IMB11 merged commit 620ff3f into FabricMC:main Mar 16, 2025
7 checks passed
@its-miroma its-miroma deleted the authors branch March 16, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

correction Something isn't right on a page

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants