adding new additional submit_to option on the cookie consent module#5193
adding new additional submit_to option on the cookie consent module#5193
Conversation
|
@codex please review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d8ccd2af4d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
|
|
||
| if ($submit_to === 'action_id') { | ||
| return ee()->functions->fetch_site_index(0, 0) . QUERY_MARKER . 'ACT=' . $action_id; |
There was a problem hiding this comment.
Using fetch_site_index(0, 0) in the submit_to='action_id' branch drops URL-based session tokens (/S=.../), so on installs that rely on non-cookie sessions this POST is handled as a new guest session instead of the current member session. In that context, consent updates can be recorded against the anonymous visitor (or fail CSRF/session validation) rather than the logged-in member, which makes this option unreliable for affected deployments.
Useful? React with 👍 / 👎.
1 participant
adding new additional submit_to option on the cookie consent module