feat: Store and read feature data as serialized protos for scylladb sorted feature view#253
Merged
piket merged 1 commit intofeature/range-query-improvementsfrom Jun 20, 2025
Conversation
piket
force-pushed
the
sortedfv-save-protos-for-nulls
branch
2 times, most recently
from
2926105 to
a6c28b6
Compare
…orted feature view refactor integration test data directory structure add build tag for unit tests for complete separation of integration and unit tests
piket
force-pushed
the
sortedfv-save-protos-for-nulls
branch
from
a6c28b6 to
12a7478
Compare
EXPEbdodla
approved these changes
Jun 18, 2025
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Due to limitations with go primitive types, we can't properly read null values for some features. To retain nulls, we need to use a serialized proto for all non-sort key features. This impacts both writing and reading data.
Which issue(s) this PR fixes:
Null feature values are properly read from scylladb
Created integration tests for full-path OnlineReadRange with ScyllaDB
Created Integration tests for Cassandra Online Store
Misc
refactor integration test data directory structure
add build tag for unit tests for complete separation of integration and unit tests
added go integration tests to PR workflow