Skip to content

Add php 8.3 to build jobs - #104

Merged
HeahDude merged 1 commit into
Exercise:masterfrom
84m:php-83
Mar 8, 2024
Merged

HeahDude merged 1 commit into
Exercise:masterfrom
84m:php-83

Conversation

@84m

@84m 84m commented Mar 8, 2024

Copy link
Copy Markdown
Contributor

Adding php8.3 to the current build jobs

@84m

84m commented Mar 8, 2024

Copy link
Copy Markdown
Contributor Author

Hey @HeahDude,
i would love approval here, to get the workflow running ;-)

@HeahDude

HeahDude commented Mar 8, 2024

Copy link
Copy Markdown
Collaborator

@84m thanks for the PR!
It seems we need to fix a bit more the workflow run on low deps, do you want to give it a try or do you want me to handle it by pushing on your branch (probably tomorrow)?

@84m

84m commented Mar 8, 2024

Copy link
Copy Markdown
Contributor Author

[...] do you want to give it a try or do you want me to handle it by pushing on your branch (probably tomorrow)?

sure, go ahead. I justed fixed the codestyle as a quick fix, but would also need to dig deeper on why the lowest-ci is currently failing.

@84m

84m commented Mar 8, 2024

Copy link
Copy Markdown
Contributor Author

short update: i think i found the issue

@HeahDude

HeahDude commented Mar 8, 2024

Copy link
Copy Markdown
Collaborator

Thank you @84m

@HeahDude
HeahDude merged commit 19615c5 into Exercise:master Mar 8, 2024
@84m
84m deleted the php-83 branch March 9, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants