fix: remove duplicate function and use specific exception types#53
Draft
fix: remove duplicate function and use specific exception types#53
Conversation
- Remove duplicate _split_yuv420_planes function in hevc_feature_decoder_mv.py - Replace broad `except Exception:` with specific types (ValueError, TypeError, OSError, IndexError, AttributeError, cv2.error) in hevc_feature_decoder.py and hevc_feature_decoder_mv.py - This improves debuggability and allows KeyboardInterrupt/SystemExit to propagate
anxiangsir
force-pushed
the
main
branch
2 times, most recently
from
3b0d868 to
f7e7781
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_split_yuv420_planesfunction definition inhevc_feature_decoder_mv.pyexcept Exception:with specific exception types in HEVC decoder filesChanges
hevc_feature_decoder.pyhevc_feature_decoder_mv.pyBenefits
KeyboardInterruptandSystemExitwill no longer be silently swallowedTest plan