fix(setup.sh): Add wget to core_packages, fix HWE package name, use shutdown -r +1 - #233
Merged
Merged
Conversation
…hutdown -r +1 Agent-Logs-Url: https://github.com/EngineScript/EngineScript/sessions/9b2c486f-ffe6-4f57-95bb-425f85499d12 Co-authored-by: PDowney <11467177+PDowney@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix installation issues by adding wget and updating UBUNTU_VERSION
fix(setup.sh): Add wget to core_packages, fix HWE package name, use shutdown -r +1
May 2, 2026
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
PDowney
approved these changes
May 2, 2026
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes several first-run reliability issues in setup.sh, the bootstrap script that prepares a fresh Ubuntu host to run EngineScript.
Changes:
- Adds
wgettocore_packagesso the required-command validation doesn’t fail on minimal images. - Adjusts the HWE kernel meta-package install command to use a dotless Ubuntu version string.
- Changes the reboot behavior to
shutdown -r +1and updates the accompanying user-facing message.
| "apt" "bash" "boxes" "cron" "coreutils" "curl" "dos2unix" "git" "gzip" "nano" | ||
| "needrestart" "openssl" "pwgen" "sed" "software-properties-common" "tar" | ||
| "tzdata" "unattended-upgrades" "unzip" "zip" | ||
| "tzdata" "unattended-upgrades" "unzip" "wget" "zip" |
Comment on lines
+224
to
+225
| UBUNTU_VERSION_NO_DOT="${UBUNTU_VERSION//./}" | ||
| apt install --install-recommends "linux-generic-hwe-${UBUNTU_VERSION_NO_DOT}" -y |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Three bugs in
setup.shthat cause installation failures or incorrect behavior on a fresh Ubuntu system.Software Version Updates
Changed Versions
No version changes — these are correctness fixes to
setup.sh.Version Diff
Verification Checklist
wgetis now installed before therequired_commandsvalidation runslinux-generic-hwe-2404, notlinux-generic-hwe-24.04)shutdown -r +1— broadcasts a system-wide warning, cancellable; message updated to reflect the ~70s actual delayNotes
wgetwas already validated as required but never installed by the script — would fail on any minimal Ubuntu image that doesn't ship it.linux-generic-hwe-24.04is not a valid apt package name; the correct name uses the dotless form (e.g.linux-generic-hwe-2404).shutdown -r nowsilently reboots with no broadcast;shutdown -r +1gives all logged-in users a standard warning.Original prompt