Skip to content

fix: reliable Ubuntu version check and safe apt glob removal in setup.sh #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PDowney merged 3 commits into from
May 2, 2026
Merged

fix: reliable Ubuntu version check and safe apt glob removal in setup.sh #231

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f2aabc
Initial plan
Copilot May 2, 2026
e08c386
Fix Ubuntu version comparison and apt-get glob quoting in setup.sh
Copilot May 2, 2026
5978c16
Update CHANGELOG.md
PDowney May 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,10 @@ fi

# Check if Ubuntu is 24.04 LTS Release. If not, exit.
UBUNTU_VERSION="$(lsb_release -sr)"
Noble=24.04
UBUNTU_VERSION_INT="$(tr -d '.' <<<"$UBUNTU_VERSION")"
NOBLE_INT=2404

if (( $(bc <<<"$UBUNTU_VERSION != $Noble") )); then
if (( UBUNTU_VERSION_INT != NOBLE_INT )); then
Comment on lines +40 to +43
echo "ALERT:"
echo "EngineScript does not support Ubuntu $UBUNTU_VERSION. We recommend using Ubuntu 24.04 LTS"
exit 1
Expand Down Expand Up @@ -197,7 +198,7 @@ if [[ "${ALIAS}" = 1 ]];
fi

# Cleanup
apt-get remove apache2* php7* php8* -y
apt-get remove --purge 'apache2*' 'php7*' 'php8*' -y

# Update & Upgrade
apt update --allow-releaseinfo-change -y
Expand Down
Loading