fix: simplify div-counting regexes and remove redundant tr pipe in admin control panel install - #223
Merged
Merged
Conversation
… control panel install Agent-Logs-Url: https://github.com/EngineScript/EngineScript/sessions/9b6adbb4-3f0c-4b1d-b75f-3f5a70cde9c0 Co-authored-by: PDowney <11467177+PDowney@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove unnecessary tr command from admin control panel script
fix: simplify div-counting regexes and remove redundant tr pipe in admin control panel install
May 1, 2026
Removed outdated section regarding admin control panel regex and pipeline cleanup.
PDowney
approved these changes
May 1, 2026
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Admin Control Panel installer’s Adminer-card removal guard to use simpler, more consistent <div>/</div> matching and to streamline the line-count pipelines used for balance checks.
Changes:
- Simplified the opening
<div ...>and closing</div>grep patterns used for div-counting. - Removed a redundant
tr -d '[:space:]'stage afterwc -lin both div-count pipelines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Software Version Updates
Two issues in the Adminer block div-balance check in
admin-control-panel-install.sh: overly complex regex patterns with unnecessary whitespace matchers, and a redundanttr -d '[:space:]'stage afterwc -l.Changed Versions
scripts/install/tools/frontend/admin-control-panel-install.sh<div[^>]*[[:space:]]*>→<div[^>]*>and</div[[:space:]]*>→</div>. The trailing[[:space:]]*before>matched nothing useful and could mask malformed tags.| tr -d '[:space:]'from both counting lines —wc -lalready emits a bare integer.Version Diff
Verification Checklist
Notes
This is an automated pull request created by the software version checker workflow.
Please verify these versions are stable releases before merging.
Original prompt