fix: resolve non-existent global function call in ExternalServicesJsonApiResponseFetcher by Copilot · Pull Request #216 · EngineScript/EngineScript

Copilot · 2026-04-22T00:08:34Z

All prior modernisation complete (enum ServiceStatus, readonly constructors, typed constants, etc.)
Created classes/CurlInitException.php — final class CurlInitException extends \RuntimeException {}
require_once CurlInitException.php added to external-services-api.php and ExternalServicesController.php
Both throw new \RuntimeException replaced with throw new CurlInitException; @throws docblocks updated
All three files pass php -l
Updated CHANGELOG.md

Original prompt

Please apply the following diffs and create a pull request.
Once the PR is ready, give it a title based on the messages of the fixes being applied.

[{"message":"This call references a non-existent function 'createSecureCurlHandle'. The method 'createSecureCurlHandle' is a private instance method of 'ExternalServicesFeedParser', not a global function. This class should either receive an instance of 'ExternalServicesFeedParser' to call the method, or duplicate the secure cURL setup logic.","fixFiles":[{"filePath":"config/var/www/admin/control-panel/external-services/external-services-api.php","diff":"diff --git a/config/var/www/admin/control-panel/external-services/external-services-api.php b/config/var/www/admin/control-panel/external-services/external-services-api.php\n--- a/config/var/www/admin/control-panel/external-services/external-services-api.php\n+++ b/config/var/www/admin/control-panel/external-services/external-services-api.php\n@@ -617,13 +617,38 @@\n class ExternalServicesJsonApiResponseFetcher\n {\n     /**\n+     * Create a secure cURL handle for JSON API requests.\n+     *\n      * @param string $apiUrl API endpoint URL\n+     * @return resource|\\CurlHandle\n+     */\n+    private function createSecureCurlHandle(string $apiUrl)\n+    {\n+        $curl = curl_init($apiUrl);\n+        curl_setopt_array($curl, [\n+            CURLOPT_RETURNTRANSFER => true,\n+            CURLOPT_FOLLOWLOCATION => false,\n+            CURLOPT_MAXREDIRS => 0,\n+            CURLOPT_CONNECTTIMEOUT => 10,\n+            CURLOPT_TIMEOUT => 30,\n+            CURLOPT_SSL_VERIFYPEER => true,\n+            CURLOPT_SSL_VERIFYHOST => 2,\n+            CURLOPT_PROTOCOLS => CURLPROTO_HTTPS,\n+            CURLOPT_REDIR_PROTOCOLS => CURLPROTO_HTTPS,\n+            CURLOPT_USERAGENT => 'EngineScript External Services Monitor'\n+        ]);\n+\n+        return $curl;\n+    }\n+\n+    /**\n+     * @param string $apiUrl API endpoint URL\n      * @return array{data: array, error: ?array}\n      */\n     public function fetch(string $apiUrl): array\n     {\n         // Reuse centralized secure cURL configuration to avoid drift/duplication.\n-        $curl = createSecureCurlHandle($apiUrl);\n+        $curl = $this->createSecureCurlHandle($apiUrl);\n \n         $response = curl_exec($curl);\n         $httpCode = curl_getinfo($curl, CURLINFO_HTTP_CODE);\n"}]}]

…nApiResponseFetcher Promote ExternalServicesFeedParser::createSecureCurlHandle() to public static, update internal caller to self::, and update ExternalServicesJsonApiResponseFetcher to call ExternalServicesFeedParser::createSecureCurlHandle() — no code duplication. Agent-Logs-Url: https://github.com/EngineScript/EngineScript/sessions/356dcbac-660c-45c0-9f5f-75ce1d21c4b6 Co-authored-by: PDowney <11467177+PDowney@users.noreply.github.com>

…n private method Agent-Logs-Url: https://github.com/EngineScript/EngineScript/sessions/01d555a3-7989-4e50-82d8-938f00024395 Co-authored-by: PDowney <11467177+PDowney@users.noreply.github.com>

Agent-Logs-Url: https://github.com/EngineScript/EngineScript/sessions/abb36eca-8166-4968-a9a3-44fdc50a6a99 Co-authored-by: PDowney <11467177+PDowney@users.noreply.github.com>

…oller Agent-Logs-Url: https://github.com/EngineScript/EngineScript/sessions/abb36eca-8166-4968-a9a3-44fdc50a6a99 Co-authored-by: PDowney <11467177+PDowney@users.noreply.github.com>

Agent-Logs-Url: https://github.com/EngineScript/EngineScript/sessions/abb36eca-8166-4968-a9a3-44fdc50a6a99 Co-authored-by: PDowney <11467177+PDowney@users.noreply.github.com>

…nstructors, typed constants, CurlHandle type, final classes Agent-Logs-Url: https://github.com/EngineScript/EngineScript/sessions/abb36eca-8166-4968-a9a3-44fdc50a6a99 Co-authored-by: PDowney <11467177+PDowney@users.noreply.github.com>

Agent-Logs-Url: https://github.com/EngineScript/EngineScript/sessions/52f701b6-41e9-4d06-915f-c643c2aee61d Co-authored-by: PDowney <11467177+PDowney@users.noreply.github.com>

Updated the changelog to reflect recent changes, including the addition of a dedicated Curl exception class and various refactorings for PHP 8.2–8.4 modernization.

github-actions · 2026-04-22T03:09:28Z

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

sonarqubecloud · 2026-04-22T03:09:40Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copilot

Pull request overview

This PR fixes an invalid call to a non-existent global createSecureCurlHandle() by centralizing secure cURL handle creation and reusing it from the JSON API response fetcher, while also modernizing and de-duplicating parts of the external services parsing stack.

Changes:

Introduced CurlInitException and switched cURL init failures from generic runtime exceptions to a dedicated exception type.
Centralized secure cURL creation via a shared trait and updated ExternalServicesJsonApiResponseFetcher to call the correct instance method.
Refactored external-services parsing to reduce duplication (shared nested-path resolver, ServiceStatus enum), and cleaned up repetitive version parsing in ServiceController.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
config/var/www/admin/control-panel/external-services/external-services-api.php	Fixes the non-existent function call by reusing a shared cURL factory; adds shared JSON path resolver and `ServiceStatus` enum refactors.
config/var/www/admin/control-panel/controllers/ServiceController.php	Consolidates repeated version parsing logic into a helper method.
config/var/www/admin/control-panel/controllers/ExternalServicesController.php	Adds `CurlInitException` loading and factors cURL setup into a reusable helper for external requests.
config/var/www/admin/control-panel/classes/CurlInitException.php	Adds a dedicated exception type for `curl_init()` failures.
CHANGELOG.md	Documents the refactor/modernisation changes.

Copilot · 2026-04-22T03:24:19Z

+     * HTML-escaped. Returns 'Unknown' when output is null or the pattern
+     * does not match.
+     *
+     * @param string|null $output Raw command output
+     * @param string $pattern PCRE pattern with one capture group for the version
+     * @return string Sanitized version string or 'Unknown'
+     */
+    private function parseVersionOutput(?string $output, string $pattern): string
+    {
+        if ($output !== null && preg_match($pattern, $output, $matches)) {


parseVersionOutput() assumes $output is null or a string, but the SystemCommand::*Version() methods return string|false. If they return false, preg_match() will throw a TypeError (bool given), which is not caught by this controller. Guard with is_string($output) before calling preg_match(), or widen the parameter type to string|false and treat false as Unknown.

Suggested change

* HTML-escaped. Returns 'Unknown' when output is null or the pattern

* does not match.

*

* @param string|null $output Raw command output

* @param string $pattern PCRE pattern with one capture group for the version

* @return string Sanitized version string or 'Unknown'

*/

private function parseVersionOutput(?string $output, string $pattern): string

{

if ($output !== null && preg_match($pattern, $output, $matches)) {

* HTML-escaped. Returns 'Unknown' when output is null, false, or the

* pattern does not match.

*

* @param string|false|null $output Raw command output

* @param string $pattern PCRE pattern with one capture group for the version

* @return string Sanitized version string or 'Unknown'

*/

private function parseVersionOutput(string|false|null $output, string $pattern): string

{

if (is_string($output) && preg_match($pattern, $output, $matches)) {

Copilot · 2026-04-22T03:24:20Z

    /**
     * @param string $apiUrl API endpoint URL
     * @return array{data: array, error: ?array}
     */
    public function fetch(string $apiUrl): array
    {
-        // Reuse centralized secure cURL configuration to avoid drift/duplication.
-        $curl = createSecureCurlHandle($apiUrl);
+        $curl = $this->createSecureCurlHandle($apiUrl);

        $response = curl_exec($curl);
        $httpCode = curl_getinfo($curl, CURLINFO_HTTP_CODE);
        curl_close($curl);



ExternalServicesJsonApiResponseFetcher::fetch() now calls createSecureCurlHandle() from SecureCurlHandleTrait, which can throw CurlInitException. That breaks fetch()'s stated contract of always returning an array{data, error} and can bubble exceptions to any future callers. Consider catching CurlInitException inside fetch() and returning FetchError, or update the method’s PHPDoc/contract to document the thrown exception and ensure all callers handle it.

Initial plan

2ac93d2

Copilot AI assigned Copilot and PDowney Apr 22, 2026

Copilot started work on behalf of PDowney April 22, 2026 00:08 View session

Copilot AI changed the title ~~[WIP] Fix call to non-existent function in external-services-api~~ fix: resolve non-existent global function call in ExternalServicesJsonApiResponseFetcher Apr 22, 2026

Copilot AI requested a review from PDowney April 22, 2026 00:11

Copilot finished work on behalf of PDowney April 22, 2026 00:11

Copilot started work on behalf of PDowney April 22, 2026 00:18 View session

fix: eliminate static cross-class cURL access, give each class its ow…

a2636bb

…n private method Agent-Logs-Url: https://github.com/EngineScript/EngineScript/sessions/01d555a3-7989-4e50-82d8-938f00024395 Co-authored-by: PDowney <11467177+PDowney@users.noreply.github.com>

Copilot finished work on behalf of PDowney April 22, 2026 00:20

Copilot started work on behalf of PDowney April 22, 2026 00:25 View session

Copilot finished work on behalf of PDowney April 22, 2026 00:26

Copilot started work on behalf of PDowney April 22, 2026 00:39 View session

Copilot AI and others added 4 commits April 22, 2026 00:44

wip: plan trait refactor for status results and path resolver

5ab3a7b

Agent-Logs-Url: https://github.com/EngineScript/EngineScript/sessions/abb36eca-8166-4968-a9a3-44fdc50a6a99 Co-authored-by: PDowney <11467177+PDowney@users.noreply.github.com>

wip: plan dedup fixes for ExternalServicesController and ServiceContr…

9d24d36

…oller Agent-Logs-Url: https://github.com/EngineScript/EngineScript/sessions/abb36eca-8166-4968-a9a3-44fdc50a6a99 Co-authored-by: PDowney <11467177+PDowney@users.noreply.github.com>

wip: convert StatusResultTrait to final class ServiceStatus

33c3d90

Agent-Logs-Url: https://github.com/EngineScript/EngineScript/sessions/abb36eca-8166-4968-a9a3-44fdc50a6a99 Co-authored-by: PDowney <11467177+PDowney@users.noreply.github.com>

Copilot finished work on behalf of PDowney April 22, 2026 01:07

Copilot started work on behalf of PDowney April 22, 2026 01:09 View session

fix: replace generic RuntimeException with dedicated CurlInitException

aeeeb92

Agent-Logs-Url: https://github.com/EngineScript/EngineScript/sessions/52f701b6-41e9-4d06-915f-c643c2aee61d Co-authored-by: PDowney <11467177+PDowney@users.noreply.github.com>

Copilot finished work on behalf of PDowney April 22, 2026 01:11

Update CHANGELOG.md for recent changes

251c658

Updated the changelog to reflect recent changes, including the addition of a dedicated Curl exception class and various refactorings for PHP 8.2–8.4 modernization.

PDowney approved these changes Apr 22, 2026

View reviewed changes

Copilot started work on behalf of PDowney April 22, 2026 03:17 View session

Copilot finished work on behalf of PDowney April 22, 2026 03:19

Copilot AI requested a review from PDowney April 22, 2026 03:19

PDowney approved these changes Apr 22, 2026

View reviewed changes

PDowney marked this pull request as ready for review April 22, 2026 03:20

Copilot AI review requested due to automatic review settings April 22, 2026 03:20

PDowney merged commit 7debf86 into master Apr 22, 2026
10 of 11 checks passed

github-actions Bot deleted the copilot/fix-non-existent-function-call branch April 22, 2026 03:21

Copilot started reviewing on behalf of PDowney April 22, 2026 03:21 View session

Copilot AI reviewed Apr 22, 2026

View reviewed changes

Navigation Menu

Uh oh!

Uh oh!

fix: resolve non-existent global function call in ExternalServicesJsonApiResponseFetcher - #216

fix: resolve non-existent global function call in ExternalServicesJsonApiResponseFetcher#216
PDowney merged 9 commits into
masterfrom
copilot/fix-non-existent-function-call

Copilot AI commented Apr 22, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 22, 2026

Uh oh!

sonarqubecloud Bot commented Apr 22, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 22, 2026

Uh oh!

Copilot AI Apr 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

Copilot AI commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 22, 2026

Dependency Review

Scanned Files

Uh oh!

sonarqubecloud Bot commented Apr 22, 2026

Quality Gate passed

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Apr 22, 2026 •

edited

Loading