Fix for Useless conditional - #210
Merged
Merged
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
|
Thanks for contributing to EngineScript! 🎉 If your PR fixes an issue or relates to a specific environment, please consider including the sanitized output We'll review your PR soon! |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes an always-true conditional check around storage.removeItem('servicePreferences') in the parse-error cleanup path of loadServicePreferences(), relying on the earlier guard that already returns when localStorage is unavailable.
Changes:
- Simplifies the parse-error cleanup block by directly calling
storage.removeItem('servicePreferences')inside the existingtry/catch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix this without changing behavior, remove the redundant truthiness check around
storage.removeItem('servicePreferences')in the parse-error cleanup block. At that point in control flow,storageis already guaranteed to exist (otherwise the function would have returned earlier), so directly callingstorage.removeItem(...)inside the existingtry/catchpreserves error handling while eliminating the always-true condition.Change region:
config/var/www/admin/control-panel/external-services/external-services.js, around lines 1507–1510 inloadServicePreferences().No new imports, methods, or dependencies are needed.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.