Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ElementsProject/rust-elements
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: ElementsProject/rust-elements
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.26.x
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 8 commits
  • 12 files changed
  • 2 contributors

Commits on Jun 15, 2026

  1. Configuration menu
    Copy the full SHA
    d216a7c View commit details
    Browse the repository at this point in the history
  2. rewrite Address::from_base58 to eliminate all the unwraps

    These unwraps and indexing (which hide more panic paths) irritated me, and also
    would need to be tweaked once we get rid of the Hash::from_slice methods. I
    figured I'd preemptively get rid of them.
    apoelstra authored and philipr-za committed Jun 15, 2026
    Configuration menu
    Copy the full SHA
    6005720 View commit details
    Browse the repository at this point in the history
  3. blind: use array splitting in TxOut::unblind (fix potential DoS?)

    I don't *think* it's possible to create a rangeproof with a sidechannel smaller
    than 64 bytes (if you create a 0-sized "proof of exact value" then unwinding
    will fail entirely, and anything larger I think has at least one ring, so 128
    bytes or more). Unsure.
    
    But better not to assume this by indexing recklessly into the sidechannel
    message.
    philipr-za committed Jun 15, 2026
    Configuration menu
    Copy the full SHA
    6659691 View commit details
    Browse the repository at this point in the history
  4. transaction: use better error typing for pegin destructuring

    We should redo the error types here as well at some point.
    philipr-za committed Jun 15, 2026
    Configuration menu
    Copy the full SHA
    acf5bc8 View commit details
    Browse the repository at this point in the history
  5. address: do a better job slicing bech32 data

    Currently we allow decoding segwit v0 programs which have uncompressed/hybrid
    keys (not allowed) and I suspect that if you provide a too-short address then
    you'll get a panic here.
    philipr-za committed Jun 15, 2026
    Configuration menu
    Copy the full SHA
    6e082a9 View commit details
    Browse the repository at this point in the history
  6. pset: fix slicing in KeySource::deserialize

    Lol, this code was so close and yet so far.
    
    pset
    philipr-za committed Jun 15, 2026
    Configuration menu
    Copy the full SHA
    4428361 View commit details
    Browse the repository at this point in the history
  7. Bump version to 0.26.2

    philipr-za committed Jun 15, 2026
    Configuration menu
    Copy the full SHA
    6fee387 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2026

  1. Merge #281: Backport slicing improvements 0.26.x

    6fee387 Bump version to 0.26.2 (Philip Robinson)
    4428361 pset: fix slicing in KeySource::deserialize (Philip Robinson)
    6e082a9 address: do a better job slicing bech32 data (Philip Robinson)
    acf5bc8 transaction: use better error typing for pegin destructuring (Philip Robinson)
    6659691 blind: use array splitting in TxOut::unblind (fix potential DoS?) (Philip Robinson)
    6005720 rewrite Address::from_base58 to eliminate all the unwraps (Andrew Poelstra)
    d216a7c Add arrays.rs and slices.rs from bitcoin-internals 0.5 (Philip Robinson)
    
    Pull request description:
    
      There are a number of useful improvements from #279 we would like to include in 0.26.x.
    
    ACKs for top commit:
      apoelstra:
        ACK 6fee387; successfully ran local tests
    
    Tree-SHA512: dd5d142dd76cbe472c67823989f79ed1bb1024282b788cd840bd4cf71db95ef277aa4eeb416ebe829a01f4dd22ed672dbc293e181bddaa9ccb0814e47dd1cc19
    apoelstra committed Jun 16, 2026
    Configuration menu
    Copy the full SHA
    cb56c8f View commit details
    Browse the repository at this point in the history
Loading