Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ElementsProject/rust-elements
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: ElementsProject/rust-elements
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.25.x
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 14 commits
  • 15 files changed
  • 2 contributors

Commits on Jun 15, 2026

  1. Configuration menu
    Copy the full SHA
    8cd2a4d View commit details
    Browse the repository at this point in the history
  2. rewrite Address::from_base58 to eliminate all the unwraps

    These unwraps and indexing (which hide more panic paths) irritated me, and also
    would need to be tweaked once we get rid of the Hash::from_slice methods. I
    figured I'd preemptively get rid of them.
    philipr-za committed Jun 15, 2026
    Configuration menu
    Copy the full SHA
    179c6da View commit details
    Browse the repository at this point in the history
  3. blind: use array splitting in TxOut::unblind (fix potential DoS?)

    I don't *think* it's possible to create a rangeproof with a sidechannel smaller
    than 64 bytes (if you create a 0-sized "proof of exact value" then unwinding
    will fail entirely, and anything larger I think has at least one ring, so 128
    bytes or more). Unsure.
    
    But better not to assume this by indexing recklessly into the sidechannel
    message.
    philipr-za committed Jun 15, 2026
    Configuration menu
    Copy the full SHA
    8b15649 View commit details
    Browse the repository at this point in the history
  4. transaction: use better error typing for pegin destructuring

    We should redo the error types here as well at some point.
    philipr-za committed Jun 15, 2026
    Configuration menu
    Copy the full SHA
    2a8b46f View commit details
    Browse the repository at this point in the history
  5. address: do a better job slicing bech32 data

    Currently we allow decoding segwit v0 programs which have uncompressed/hybrid
    keys (not allowed) and I suspect that if you provide a too-short address then
    you'll get a panic here.
    philipr-za committed Jun 15, 2026
    Configuration menu
    Copy the full SHA
    b06dac9 View commit details
    Browse the repository at this point in the history
  6. pset: fix slicing in KeySource::deserialize

    Lol, this code was so close and yet so far.
    
    pset
    philipr-za committed Jun 15, 2026
    Configuration menu
    Copy the full SHA
    250c4f6 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    2941a39 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    70276cc View commit details
    Browse the repository at this point in the history
  9. add --no-deps to doc test

    philipr-za committed Jun 15, 2026
    Configuration menu
    Copy the full SHA
    ea42e11 View commit details
    Browse the repository at this point in the history
  10. Pin deps for Fuzztest job

    philipr-za committed Jun 15, 2026
    Configuration menu
    Copy the full SHA
    675ca26 View commit details
    Browse the repository at this point in the history
  11. Fix docstring in blech32

    philipr-za committed Jun 15, 2026
    Configuration menu
    Copy the full SHA
    6275989 View commit details
    Browse the repository at this point in the history
  12. Bump version to 0.25.3

    philipr-za committed Jun 15, 2026
    Configuration menu
    Copy the full SHA
    ad00563 View commit details
    Browse the repository at this point in the history
  13. Disable fuzztest in CI

    philipr-za committed Jun 15, 2026
    Configuration menu
    Copy the full SHA
    982a50f View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2026

  1. Merge #280: Backport slicing improvements to 0.25.x

    982a50f Disable fuzztest in CI (Philip Robinson)
    ad00563 Bump version to 0.25.3 (Philip Robinson)
    6275989 Fix docstring in blech32 (Philip Robinson)
    675ca26 Pin deps for Fuzztest job (Philip Robinson)
    ea42e11 add `--no-deps` to doc test (Philip Robinson)
    70276cc pin bitcoin crates in test.sh (Philip Robinson)
    2941a39 Remove `-- -D warnings` from test.sh (Philip Robinson)
    250c4f6 pset: fix slicing in KeySource::deserialize (Philip Robinson)
    b06dac9 address: do a better job slicing bech32 data (Philip Robinson)
    2a8b46f transaction: use better error typing for pegin destructuring (Philip Robinson)
    8b15649 blind: use array splitting in TxOut::unblind (fix potential DoS?) (Philip Robinson)
    179c6da rewrite Address::from_base58 to eliminate all the unwraps (Philip Robinson)
    8cd2a4d Add arrays.rs and slices.rs from bitcoin-internals 0.5 (Philip Robinson)
    
    Pull request description:
    
      There are a number of useful improvements from #279 we would like to include in 0.25.x.
    
    ACKs for top commit:
      apoelstra:
         utACK 982a50f
    
    Tree-SHA512: 51f786c01982d107193f9e75be13a1087a24372664eb70fbbb0eb3ee3d2bfbf64b94ac573a22fe20d412c717f54d5c3a37a4010099fe6d56892fdd486e026c62
    apoelstra committed Jun 16, 2026
    Configuration menu
    Copy the full SHA
    4a38059 View commit details
    Browse the repository at this point in the history
Loading