Skip to content

grpc2py.py: generator emits flake8 E261/F401 violations in generated output #9128

@nGoline

Description

@nGoline

The msggen generator at contrib/msggen/msggen/gen/grpc2py.py produces code that fails the project's own pre-commit flake8 hook, making it impossible to commit a regenerated grpc2py.py without --no-verify.

Violations

F401 — unused import (grpc2py.py:5)

The generator header template (line 85 of the generator) emits import json into every generated file, but json is never referenced anywhere in the generated output.

E261 — inline comment spacing (multiple lines)

PEP 8 requires at least two spaces before an inline # comment.

The following functions are producing a incorrect comment

Generator line 111: def decodekeysend_routes2py(m): # manual override have a single space : # .

Generator line 124: def decodepay_routes2py(m): # manual override have a single space `: # .

The ArrayField[primitive] branch (generator line 191) produces , # (one space):

f'        "{name}": [{rhs} for i in {rhs}], # ArrayField[primitive] in generate_composite\n',

The PrimitiveField (line 184) and ArrayField[composite] (line 201) branches correctly use , # (two spaces):

f'        "{name}": {rhs},  # PrimitiveField in generate_composite\n',
...
f'        "{name}": [{rhs} for i in m.{name}],  # ArrayField[composite] in generate_composite\n',

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions