Use ElectronPackageId instead of PackageId #990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pr-comment: Run #4
🎉 All tests passed!Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request renames the PackageId MSBuild property to ElectronPackageId throughout the codebase to avoid conflicts with NuGet's standard PackageId property. This is a breaking change that affects project configuration but provides better compatibility with the .NET build system.
Key changes:
- Renamed the MSBuild property from
PackageIdtoElectronPackageIdacross all build files - Updated documentation to reflect the new property name
- Modified the Visual Studio project designer property definition
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/ElectronNET/build/package.template.json | Updated template placeholders to use $(ElectronPackageId) for package name, app ID, and executable name |
| src/ElectronNET/build/ElectronNETRules.Project.xaml | Renamed property definition from PackageId to ElectronPackageId in Visual Studio designer |
| src/ElectronNET/build/ElectronNET.LateImport.targets | Updated template property binding and electron-builder parameter to use ElectronPackageId |
| src/ElectronNET/build/ElectronNET.Core.targets | Changed executable name logic for non-Windows platforms to reference ElectronPackageId |
| src/ElectronNET/build/ElectronNET.Core.props | Updated default property initialization to use ElectronPackageId |
| docs/Using/Configuration.md | Updated configuration documentation with new property name in examples |
| docs/Core/Migration-Checks.md | Updated migration guide example to use ElectronPackageId |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
FlorianRappl
approved these changes
Dec 16, 2025
Collaborator
FlorianRappl
left a comment
FlorianRappl
left a comment
There was a problem hiding this comment.
LGTM - thanks for providing a fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #989 (comment)
Please test, I don't have time ATM.