Fix animation event editor runtime FPS scale - #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Event.frameon a fixed 30fps scale.AnimationDatatiming.Description
RuntimeEventFrameRateconstant set to30and initialized the editor's_frameRatefrom it instead of the clip sample rate.IntegerFieldlabeledRuntime Event FPSand added a tooltip that explains events are stored on the runtime 30fps scale.ResetForClipto restore the runtime FPS instead of readingAnimationClip.frameRateso loading clips no longer changes the editor's event-frame domain.AnimationManagerbehavior were made.Testing
git diff --checkto validate no whitespace/conflict issues and it passed.command -v Unity || command -v unity-editor || command -v dotnet || trueand none was available so an editor/compile run could not be performed in this environment.Codex Task