Skip to content

Dev 4.0 - #8

Merged
Eerrly merged 5 commits into
mainfrom
dev_4.0
Jun 2, 2026
Merged

Dev 4.0#8
Eerrly merged 5 commits into
mainfrom
dev_4.0

Conversation

@Eerrly

@Eerrly Eerrly commented Jun 2, 2026

Copy link
Copy Markdown
Owner

1.删除不必要的文件
2.增加动画数据编辑器
3.增加启动服务器快速按钮

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 27d32681be

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +482 to +483
if (_clip != null)
_frameRate = Mathf.Max(1, Mathf.RoundToInt(_clip.frameRate));

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep event frames on the runtime 30fps scale

When a loaded clip has a frame rate other than 30, this default changes the editor's frame numbers into the clip's FPS domain, but the runtime still converts Event.frame as 30fps in AnimationManager.Initialize (3333333 * animEvent.frame / 100000000). For example, adding a Fire event at 0.5s on a 60fps clip writes frame 30, which the runtime treats as 1.0s, so generated/updated AnimationData fires events at the wrong times unless the user manually notices and resets the FPS to 30.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codex fix the issue

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

  • Added a RuntimeEventFrameRate constant and initialized event-frame editing to the runtime 30fps scale used by AnimationManager, preventing clip sample rates like 60fps from changing exported event timing.
  • Changed the FPS control to a read-only “Runtime Event FPS” field with a tooltip explaining that event frames remain on the 30fps runtime scale regardless of the clip sample rate.
  • Updated clip resets to restore the runtime 30fps scale instead of copying AnimationClip.frameRate.

Testing

  • git diff --check
  • ⚠️ command -v Unity || command -v unity-editor || command -v dotnet || true (no local Unity/.NET CLI available in the environment for a compile run)

Committed the change with 20fa7b5 and created the follow-up PR: Fix animation event editor runtime FPS scale.

View task →

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codex Merge the changes from the github-mention-dev-4.0 branch into the current branch

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

Testing / Checks

  • git diff --check
  • git status --short
  • ⚠️ git merge github-mention-dev-4.0 — the named branch ref is not present locally, but the current branch already contains the merge commit for that follow-up branch.
  • ⚠️ git merge codex/github-mention-dev-4.0 || true — also unavailable as a local ref; no working-tree changes resulted.

View task →

@Eerrly
Eerrly merged commit d11684b into main Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant