Optimize LoomManager async scheduling path - #7
Merged
Eerrly merged 1 commit intoApr 13, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
LoomManager's async scheduling and delayed-invocation loops while keeping the overall structure unchanged.Description
ThreadPoolMaxWorkerThreadsandThreadPoolMinWorkerThreadsand use them inInitializeto replace magic numbers.WaitCallbackin the readonly field_runActionCallback(assigned in the new constructor) and use it instead of allocatingnew WaitCallback(RunAction)on each dispatch._waitingAsyncActionsfor safe enqueue/dequeue and changeUpdateto dequeue a single waiting action under lock then schedule it, preventing double-dequeue and races.Time.unscaledTimeandTime.frameCountat the start ofUpdateand use the cached values inside the delay loops to reduce repeated Unity API calls.Testing
Codex Task