VC-11716 reset snapshot when error cell is rendered#72
Merged
eclipse-rmo merged 1 commit intomasterfrom Dec 20, 2024
Merged
Conversation
bgever
approved these changes
Dec 20, 2024
eclipse-rmo
deleted the
VC-11716-reset-snapshot-after-error-cell-being-rendered
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the hypergrid, there is a lazy rendering logic that only renders a cell if the cell's state matches the previously rendered snapshot.
A small bug exists in this logic: when an error cell is rendered, the snapshot is not updated. Consequently, if the error cell returns to its previous value, the hypergrid assumes the cell has not changed and will not re-render it. This situation causes the error cell to stay.