Skip to content

Some of this appears to have been already covered in PR #663 - #670

Merged
kwwall merged 32 commits into
ESAPI:developfrom
xeno6696:develop
Apr 8, 2022
Merged

kwwall merged 32 commits into
ESAPI:developfrom
xeno6696:develop

Conversation

@xeno6696

Copy link
Copy Markdown
Collaborator

My github repo still shows that I'm ahead of ESAPI by 21 commits, which includes all of these. This makes no sense since @kwwall shows it was merged.

At any rate, only the two commits from today are any different from PR #663

Matt Seil and others added 21 commits April 4, 2021 10:33
…g.apache.felix:maven-bundle-plugin:manifest'.
… 'mvn org.apache.felix:maven-bundle-plugin:manifest'."

This reverts commit 9fa2a53.
…h the HTTP maxes defined in esapi.properties.
…alue sizes as well as the 'Cookie' versions of those statements. Added unit tests.
@xeno6696

Copy link
Copy Markdown
Collaborator Author

@kwwall I'm researching the build failure. I didn't touch anything in encryption, so it seems odd.

@kwwall

kwwall commented Mar 19, 2022 via email

Copy link
Copy Markdown
Contributor

@kwwall

kwwall commented Mar 19, 2022

Copy link
Copy Markdown
Contributor

@xeno6696 - Never mind. I thought you meant personal tests. I wonder what the
HTTPUtilitiesTest.testGetStateFromEncryptedCookie:426 NullPointer
error is all about. That looks like something that you were tweaking.

@xeno6696

Copy link
Copy Markdown
Collaborator Author

It’s something I missed: I got so used to ignoring encryptor tests I only tested the classes I touched. This is related to the Cookie.

Half-jokingly, it’s on the Authenticator api so my gut wants to just delete it. (I don’t think anyone, anywhere uses it.)

but I’ll be good and straighten it out.

@kwwall

kwwall commented Mar 19, 2022

Copy link
Copy Markdown
Contributor

@xeno6696 - That's good that you're looking at it bc I really need to start looking at my taxes. I haven't even started started on them and I need to get them to my CPA no later than Friday or so.

@xeno6696

Copy link
Copy Markdown
Collaborator Author

Should be good to go whenever you're satisfied @kwwall

If my branch still isn't syncing properly, I'll just kill my fork and reclone.

@xeno6696

xeno6696 commented Apr 3, 2022

Copy link
Copy Markdown
Collaborator Author

@kwwall @jeremiahjstacey just leaving a breadcrumb here. I'd like someone else to validate that dropping @ignore as noted in the last commit still results in a DOS.

xeno6696 added 3 commits April 3, 2022 13:57
… opened up on github. One of which however reminded me that we need a codec to account for UTF-8 encoding/decoding.
Validator v = ESAPI.validator();
boolean expected = false;
boolean result = v.isValidInput("HTTPHeaderValue ", "mary.poppins@gmail.com", "HTTPHeaderValue", 2147483647, true, true);
assertEquals(expected, result);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh, why not just assertFalse() here instead of setting expected to false and using assertEquals() here? I'd recommend parting it after the previous test (lines 1128-1129).

@kwwall

kwwall commented Apr 6, 2022

Copy link
Copy Markdown
Contributor

@kwwall @jeremiahjstacey just leaving a breadcrumb here. I'd like someone else to validate that dropping @ignore as noted in the last commit still results in a DOS.

Other than running the tests until it crashes with an OutOfMemoryError, or running it with a debugger, how would you propose to do that? DoS vulnerabilities are generally hard to write unit tests for anyway.

assertEquals( expected, htmlCodec.decode("你") );
}

public void testUnicodeCanonicalize() {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should at least add a comment here to refer to the appropriate GitHub issue #.

@kwwall
kwwall merged commit 5db31cf into ESAPI:develop Apr 8, 2022
@kwwall

kwwall commented Oct 11, 2022 via email

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants