Merged
Conversation
added 2 commits
August 5, 2022 14:28
…compatible versions
… entitySize on first call to getSize() - this was causing obscure bugs in downstream clients when they implemented automatic retry logic
twincitiesguy
pushed a commit
to EMCECS/ecs-object-client-java
that referenced
this pull request
Aug 5, 2022
…assumes EMCECS/smart-client-java#22 will be included in 3.0.1)
dunedodo
approved these changes
Aug 7, 2022
Contributor
dunedodo
left a comment
dunedodo
left a comment
There was a problem hiding this comment.
It really makes sense. also I've found "responsibility to compute the actuall content-length header value has been delegated to JAX-RS runtime" in JAX-RS 2.0. I will continue to fix this in my thread.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SizeOverrideWriter was removing the ThreadLocal entitySize value on first call to getSize(). This was causing obscure bugs in downstream clients when they implemented automatic retry logic (any subsequent retry calls would no longer have a Content-Length header).
Calling code needs to be aware that the entitySize is no cleared from SizeOverrideWriter automatically, so they are now responsible for making sure that does not impact their logic.