Merged
Conversation
…nge to SmartFilter and an added test case to make sure URL rewrites preserve all path components properly
xiaoxin-ren
approved these changes
Jul 16, 2021
Contributor
xiaoxin-ren
left a comment
xiaoxin-ren
left a comment
There was a problem hiding this comment.
Looks good to me, thanks!
Contributor
Author
|
I have eric as reviewer and it’s a really small change.. and I’d really like it to be on maven central today, so I can use it in CI builds
… On Jul 16, 2021, at 6:41 AM, xiaoxin-ren ***@***.***> wrote:
@xiaoxin-ren approved this pull request.
Looks good to me, thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updated dependency versions, including httpclient, which needed a change to SmartFilter and an added test case to make sure URL rewrites preserve all path components properly