Open
Conversation
xiaoxin-ren
requested changes
Mar 12, 2025
xiaoxin-ren
requested changes
Mar 12, 2025
Contributor
xiaoxin-ren
left a comment
xiaoxin-ren
left a comment
There was a problem hiding this comment.
You'll need to pass the idle time to SmartConfig in S3JerseyClient. Best is to add a test case so that we can verify the behavior.
dunedodo
force-pushed
the
feature-MaxConnectionIdleTime-configurable
branch
from
a5df06a to
bdd2dfa
Compare
Contributor
Author
|
If we need UT, it should be first in smart-client? like testConnTimeout in SmartClientTest. And we might need more changes on SmartClientFactory which tell when a connection is closed and re-established, that would be complex. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.