This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Merged
Conversation
This reverts commit 3f487ee.
Contributor
|
Looks fine to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts #885 and, instead, does the MD5 calculation using nsICryptoHash. I found that rewiring the SSL Observatory submission and whitelisting code to use pure SHA256 was too big a task to get done in the appropriate timeframe for fixing this bug. So now we're back to MD5+SHA1.
cc @pde @cooperq for review. I'd like to try and put this in a release tomorrow or Monday.