Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Switch to spanning incognito#4059

Merged
jsha merged 1 commit intoEFForg:masterfrom
semenko:spanning-incognito
Feb 1, 2016
Merged

Switch to spanning incognito#4059
jsha merged 1 commit intoEFForg:masterfrom
semenko:spanning-incognito

Conversation

@semenko
Copy link
Copy Markdown
Contributor

@semenko semenko commented Jan 31, 2016

Fixes:

  • Stops us from ~doubling memory usage on incognito (by instantiating again)
  • Rule preferences & custom rules are shared in incognito

This is a little verbose, since:

  • There's no easy way to see when incognito sessions are destroyed, and we
    don't want to maintain additional state about window IDs.
  • We need to clear caches when incognito sessions are destroyed, like Chrome
    does for about:net-internals/#dns, for example.

Closes #4034

Signed-off-by: Nick Semenkovich semenko@alum.mit.edu

@semenko
Switch to spanning incognito
4e63c0f 
Fixes:
- Stops us from ~doubling memory usage on incognito (by instantiating again)
- Rule preferences & custom rules are shared in incognito

This is a little verbose, since:
- There's no easy way to see when incognito sessions are destroyed, and we
don't want to maintain additional state about window IDs.
- We need to clear caches when incognito sessions are destroyed, like Chrome
does for about:net-internals/#dns, for example.

Closes #4034

Signed-off-by: Nick Semenkovich <semenko@alum.mit.edu>
@semenko
Copy link
Copy Markdown
Contributor Author

semenko commented Jan 31, 2016

Ptal @jsha (and @TheRyuu).

These APIs are supported by WebExtensions. See:
https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/Windows/onCreated
https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/Windows/onRemoved
https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/Windows/getAll

@semenko semenko added the chrome label Jan 31, 2016
@jsha
Copy link
Copy Markdown
Member

jsha commented Feb 1, 2016

This looks nice, but can you double check what the intended promises of incognito mode are?

If the goal is "state is gone when you leave incognito," this accomplishes it.

If the goal is "state does not leak from cognito to incognito," this does not accomplish it: incognito mode windows can theoretically whether you've visited a given site from a cognito window, by the timing information available in the cache.

@semenko
Copy link
Copy Markdown
Contributor Author

semenko commented Feb 1, 2016

Chrome's consumer description:

"Incognito mode only prevents Chrome from saving your site visit activity." https://support.google.com/chrome/answer/95464?hl=en

The developer summary:

"When in Incognito mode, Chrome on desktop platforms (Windows, Linux, and Mac OS X), Chrome on Android, and Chrome OS do not store any new history, cookies, or other state in non-volatile storage. However, Incognito windows will be able to access some previously-stored state, such as browsing history."
https://www.chromium.org/Home/chromium-security/security-faq#TOC-What-are-the-security-and-privacy-guarantees-of-Incognito-mode-

So this should be good to merge.

jsha added a commit that referenced this pull request Feb 1, 2016
@jsha
Merge pull request #4059 from semenko/spanning-incognito
d433f38 
Switch to spanning incognito
@jsha jsha merged commit d433f38 into EFForg:master Feb 1, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

chrome

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@semenko @jsha