Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Better obs whitelisting#276

Merged
pde merged 20 commits intomasterfrom
better-obs-whitelisting
May 16, 2014
Merged

Better obs whitelisting#276
pde merged 20 commits intomasterfrom
better-obs-whitelisting

Conversation

@pde
Copy link
Copy Markdown
Contributor

@pde pde commented May 9, 2014

Hi Yan/Mike,

This is my code to fetch copies of the whitelist periodically from s.eff.org, rather than having every single client submit each new common cert as it is deployed.

Should massively reduce the dynamic workload on the observatory server, at the expense of a new static load at s.eff.org.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need nsITimer. This code lazily updates the whitelist whenever an amount of time has expired and there's a new submission about to be made to the observatory. One silly thing is that the cert update is async in the background while the observatory submission continues. It might make sense to chain callbacks so that the submission logic waits for maybeUpdateCertWhitelist() to finish its async work so that the submission uses the very latest whitelist. However that is going to be a bit ugly...

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, the async version would look something like this, though that's untested. I'm inclined to just merge this branch without the async acrobatics for now.

pde pushed a commit that referenced this pull request May 16, 2014
Better obs whitelisting

The less ugly but also less async version
@pde pde merged commit e391f04 into master May 16, 2014
@pde pde mentioned this pull request Jan 15, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants