This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Fix allowing global installation of Firefox extension#255
Merged
diracdeltas merged 2 commits intomasterfrom May 23, 2014
unknown repository
Merged
Fix allowing global installation of Firefox extension#255diracdeltas merged 2 commits intomasterfrom unknown repository
diracdeltas merged 2 commits intomasterfrom
unknown repository
Conversation
ghost
mentioned this pull request
Contributor
|
Hi, this looks good but one request: could you put the comments from #246 into the commit messages? Otherwise it's very difficult for someone looking at this later to figure out what's going on. |
Author
|
Done. I have included the comments in the commit message. |
Member
|
Yan, can you merge this pull request in time for the next release? |
diracdeltas
added a commit
that referenced
this pull request
May 23, 2014
Fix allowing global installation of Firefox extension
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue (#246) whereby the Firefox extension does not work if installed globally.
After some research, it is determined that the issue is caused by hardcoding of rulesets.sqlite's (the master rules database's) location. It is hardcoded as paths
["extensions", "https-everywhere@eff.org", "defaults", "rulesets.sqlite"]from the profile directory ("ProfD"). Unfortunately, if the extension is not installed in the profile directory (installed globally, for example), the database could not be loaded and therefore no requests would be converted to HTTPS.This commit fixes the issue by improving the way the extension locate the database. The database is now included in the chrome:// namespace by modifying the chrome.manifest file, and its location is determined by converting the chrome:// URL with the
chromeToPath()function.