Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Install the latest chromedriver for chrome beta#19843

Merged
zoracon merged 3 commits intoEFForg:masterfrom
cschanaj:automate-chromedriver-install2
Dec 11, 2020
Merged

Install the latest chromedriver for chrome beta#19843
zoracon merged 3 commits intoEFForg:masterfrom
cschanaj:automate-chromedriver-install2

Conversation

@cschanaj
Copy link
Copy Markdown
Collaborator

@cschanaj cschanaj commented Dec 10, 2020

Follow up #19838 (comment)

This PR updates the Travis setup script to always install the latest chromedriver for chrome beta (hard-coding is no longer need).

cc @zoracon @ghostwords

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring existing code
  • New Ruleset
  • Existing Ruleset

@cschanaj cschanaj changed the title Update setup_travis.sh Install the latest chromedriver versions for chrome beta Dec 10, 2020
@cschanaj cschanaj changed the title Install the latest chromedriver versions for chrome beta Install the latest chromedriver for chrome beta Dec 10, 2020
@cschanaj cschanaj marked this pull request as ready for review December 10, 2020 06:31
@cschanaj cschanaj requested a review from zoracon December 10, 2020 06:32
Copy link
Copy Markdown
Contributor

@zoracon zoracon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for finding a better way to handle this!

@zoracon zoracon merged commit 523caa7 into EFForg:master Dec 11, 2020
@cschanaj cschanaj deleted the automate-chromedriver-install2 branch December 12, 2020 06:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants