Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Emphasize temporary exceptions in EASE mode, fix #18970#19829

Merged
zoracon merged 13 commits intoEFForg:masterfrom
cschanaj:fix18970
Jan 16, 2021
Merged

Emphasize temporary exceptions in EASE mode, fix #18970#19829
zoracon merged 13 commits intoEFForg:masterfrom
cschanaj:fix18970

Conversation

@cschanaj
Copy link
Copy Markdown
Collaborator

@cschanaj cschanaj commented Dec 3, 2020

Fixes #18970 Fixes #19825

This PR emphasize temporary exceptions in EASE mode as requested in #18970 and #19825. See below for a preview of the new cancel page.

I have included bootstrap as a new dependency because I believe that a responsive UI will be much more user-friendly. By using a CSS framework throughout the project will also add consistency to the extension design. As FF83 introduces the HTTPS-Only Mode, I am inclined to think HTTPSE should shift the focus to mobile browsers where the security features are less extensive as compared to their Desktop alternatives. A responsive UI could be the first step to attract the mobile users to try HTTPS Everywhere.

Only the bootstrap CSS are included at the moment. Feel free to close this if it is not desirable to include a third-party framework/ it conflicts with the extension redesign planning. Thanks.

image

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring existing code
  • New Ruleset
  • Existing Ruleset

For Rulesets: Testing

  • Travis CI completed without errors (triggered upon pull request)

Existing Contributors

If you have open PRs that have not been closed or merged, please revisit them by searching: https://github.com/EFForg/https-everywhere/issues?q=is%3Aopen+assignee%3A[yourusernamehere].

@zoracon
Copy link
Copy Markdown
Contributor

zoracon commented Dec 3, 2020

I will cross check this with our internal design team, to check for consistency and feedback.

I like this approach, however I would like to refrain from Bootstrap and utilize native CSS frameworks like CSS Grid and Flexbox, which is supported in all major browsers.

@zoracon
Copy link
Copy Markdown
Contributor

zoracon commented Dec 3, 2020

Update: Internal review pending

@zoracon zoracon added EASE Encrypt all sites eligible (#16985) ui labels Dec 3, 2020
@zoracon zoracon self-assigned this Dec 3, 2020
@zoracon
Copy link
Copy Markdown
Contributor

zoracon commented Dec 3, 2020

Feedback from EFF Design

"Hi there, thanks for submitting this issue!
Our design team uses the following considerations when thinking about design changes. That said,

While we may not go with Bootstrap specifically, you make a great point regarding making the page responsive, and we're talking about how we can factor a responsive grid into our page designs going forward.

Separate styling for the URL:http://___ is a good suggestion. We might go with a different monospaced typeface choice, such as VeraMono, which we use on Certbot.eff.org for strings.

Different styling for the "Copy URL" button is a good suggestion, and we like how you stacked it (though we might bump up the button size to be a bit more uniform). To meet color contrast standards, we might suggest adding a border to the button, or upping the contrast in a different manner, since the present light grey is hard to distinguish from the white background.

The wording that you suggest for the buttons is an improvement, and we really appreciate your contributions on that. We quite like "Proceed anyway (unsafe)" and "Disable for this site", and are recommending making that change. The change for "Proceed anyway (unsafe)" to being the only one red is a nice change as well.

Thanks again for your contribution!"

For the typeface and Grid CSS, and other feedback I can submit a commit adding to this PR. It will then go under review again. I know this process is new in our repo, but trying to normalize these steps for future design contributions this so thank you for your patience!

@cschanaj
Copy link
Copy Markdown
Collaborator Author

cschanaj commented Dec 4, 2020

Thank you @zoracon and EFF design teams for the quick and useful response. I agree that using native Grid CSS and a typeface which align with EFF overall design guidelines are great idea. Please feel free to add more commits to my PR and ping me anytime for testing.

When I created this PR and I was also looking into modifying the extension option page. We have notably different design/ themed UI elements, e.g. buttons in the extension popup, option and cancel pages. It would be great if EFF design team could provide a master CSS/ SCSS file which we can follow and use consistently across this project.

@zoracon
Copy link
Copy Markdown
Contributor

zoracon commented Dec 4, 2020

@cschanaj A master file is a great suggestion and I will definitely discuss this with our design people. Coordination with design hasn't always been stable but I am doing my best to integrate better design guidance for this project.

- Utilize CSS grid for native flexibility
- Adjust Copy button
- Keep suggested langauge
- Adjust Grid for responsiveness
@zoracon
Copy link
Copy Markdown
Contributor

zoracon commented Dec 21, 2020

I have new commit in with adjustments. Had to commit some groundwork for CSS files and global variables.

I have below what it looks like now with suggestions from EFF Design and @cschanaj

EFF is going on holiday soon, so won't be able to get the proper sign off until after the holidays (Dec. 24-January 3)

Desktop:
image

Tablet:
image

Mobile:
image

@cschanaj
Copy link
Copy Markdown
Collaborator Author

cschanaj commented Dec 22, 2020

@zoracon they look great to me. thank you so much for the excellent work!

@pipboy96
Copy link
Copy Markdown
Contributor

pipboy96 commented Dec 23, 2020

@zoracon It would be better if a "Back to safety" button was added, and the other actions were less emphasized than "Back to safety" (see default browser error pages for example).

@zoracon
Copy link
Copy Markdown
Contributor

zoracon commented Jan 6, 2021

@zoracon It would be better if a "Back to safety" button was added, and the other actions were less emphasized than "Back to safety" (see default browser error pages for example).

@pipboy96 I can run that by UX review for an added workflow, for now we can get these changes in.

- Continuity with contrast
- Adjust layout spacing
@zoracon
Copy link
Copy Markdown
Contributor

zoracon commented Jan 15, 2021

Pushed in a final round of minor edits and will merge soon

@zoracon
Copy link
Copy Markdown
Contributor

zoracon commented Jan 15, 2021

Just adding the last round's feedback for context

Thanks for sending that ticket and asking me about the designs. Just checked in with the design team 🙂

Overall, we approve of the changes! We had a few suggestions (ranging from easy changes to something that might require more work) if it’s helpful.

Easier change:
We’d like to increase the white space between the logo and text above. Image included for reference around general breathing room.

Easier change:
We thought the URL still gets a little lost. We wanted to suggest a way to differentiate the http://badssl.com text from the rest of the text. A suggestion was to use #666666 grey (a11y compliant at a large size of 14pt), and to bold the monospaced font.
..
We like the way the buttons stack on tablet and mobile, but thought the 3 buttons on desktop look a little awkward. We were wondering about moving the “copy URL” button logo to the right of the link. (It could even be an icon instead of a button.)

@zoracon zoracon merged commit 0f162a8 into EFForg:master Jan 16, 2021
@cschanaj cschanaj deleted the fix18970 branch January 16, 2021 03:34
@cschanaj
Copy link
Copy Markdown
Collaborator Author

Thank you!!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

EASE Encrypt all sites eligible (#16985) ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warning screen actions improvements Emphasize temporary exceptions over permanent ones.

3 participants