Emphasize temporary exceptions in EASE mode, fix #18970#19829
Emphasize temporary exceptions in EASE mode, fix #18970#19829zoracon merged 13 commits intoEFForg:masterfrom cschanaj:fix18970
Conversation
|
I will cross check this with our internal design team, to check for consistency and feedback. I like this approach, however I would like to refrain from Bootstrap and utilize native CSS frameworks like CSS Grid and Flexbox, which is supported in all major browsers. |
|
Update: Internal review pending |
Feedback from EFF Design
For the typeface and Grid CSS, and other feedback I can submit a commit adding to this PR. It will then go under review again. I know this process is new in our repo, but trying to normalize these steps for future design contributions this so thank you for your patience! |
|
Thank you @zoracon and EFF design teams for the quick and useful response. I agree that using native Grid CSS and a typeface which align with EFF overall design guidelines are great idea. Please feel free to add more commits to my PR and ping me anytime for testing. When I created this PR and I was also looking into modifying the extension option page. We have notably different design/ themed UI elements, e.g. buttons in the extension popup, option and cancel pages. It would be great if EFF design team could provide a master CSS/ SCSS file which we can follow and use consistently across this project. |
|
@cschanaj A master file is a great suggestion and I will definitely discuss this with our design people. Coordination with design hasn't always been stable but I am doing my best to integrate better design guidance for this project. |
- Utilize CSS grid for native flexibility - Adjust Copy button - Keep suggested langauge - Adjust Grid for responsiveness
|
I have new commit in with adjustments. Had to commit some groundwork for CSS files and global variables. I have below what it looks like now with suggestions from EFF Design and @cschanaj EFF is going on holiday soon, so won't be able to get the proper sign off until after the holidays (Dec. 24-January 3) |
|
@zoracon they look great to me. thank you so much for the excellent work! |
|
@zoracon It would be better if a "Back to safety" button was added, and the other actions were less emphasized than "Back to safety" (see default browser error pages for example). |
- Continuity with contrast - Adjust layout spacing
|
Pushed in a final round of minor edits and will merge soon |
|
Just adding the last round's feedback for context
|
|
Thank you!! |



Fixes #18970 Fixes #19825
This PR emphasize temporary exceptions in EASE mode as requested in #18970 and #19825. See below for a preview of the new cancel page.
I have included bootstrap as a new dependency because I believe that a responsive UI will be much more user-friendly. By using a CSS framework throughout the project will also add consistency to the extension design. As FF83 introduces the HTTPS-Only Mode, I am inclined to think HTTPSE should shift the focus to mobile browsers where the security features are less extensive as compared to their Desktop alternatives. A responsive UI could be the first step to attract the mobile users to try HTTPS Everywhere.
Only the bootstrap CSS are included at the moment. Feel free to close this if it is not desirable to include a third-party framework/ it conflicts with the extension redesign planning. Thanks.
Type of change
For Rulesets: Testing
Existing Contributors
If you have open PRs that have not been closed or merged, please revisit them by searching:
https://github.com/EFForg/https-everywhere/issues?q=is%3Aopen+assignee%3A[yourusernamehere].