This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Use native bytes value as the default sort order#19025
Merged
zoracon merged 1 commit intoEFForg:masterfrom Apr 14, 2020
cschanaj:native-bytes
Merged
Use native bytes value as the default sort order#19025zoracon merged 1 commit intoEFForg:masterfrom cschanaj:native-bytes
zoracon merged 1 commit intoEFForg:masterfrom
cschanaj:native-bytes
Conversation
Contributor
|
Could you specify impact it has on the sort order. I get the localization aspect but was this causing some sort of error if the native bytes weren't in use? Not questioning to be contrary, just genuinely trying to understand what the underlying issue was. |
Contributor
|
@zoracon The main issue is that sorting may be inconsistent between machines that have different locales. |
Collaborator
Author
Contributor
|
Thank you both for explaining a bit further, I'm not as sharp as possible of seeing multiple cases for contributors around the world. I also like a running record of commentary for changes. So I appreciate it and will merge this in. Thank you! |
zoracon
approved these changes
Apr 14, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per the documentation
sort(1)