Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Update and rename MediaPost.xml to MediaPost.com.xml#19010

Merged
zoracon merged 4 commits intoEFForg:masterfrom
cschanaj:mediapost-com
Mar 14, 2020
Merged

Update and rename MediaPost.xml to MediaPost.com.xml#19010
zoracon merged 4 commits intoEFForg:masterfrom
cschanaj:mediapost-com

Conversation

@cschanaj
Copy link
Copy Markdown
Collaborator

@cschanaj cschanaj marked this pull request as ready for review March 10, 2020 11:43
@cschanaj cschanaj closed this Mar 10, 2020
@cschanaj cschanaj reopened this Mar 10, 2020
@cschanaj
Copy link
Copy Markdown
Collaborator Author

cschanaj commented Mar 10, 2020

#18967 force contributors to introduce obscure changes when their working branch and the master branch have a different utils\ruleset-whitelist.csv (See Travis logs and Files changed tab of this PR for more details). IMHO, this will confuse some new contributors and affect the work of reviewers if they rely on Github to preview the PR. Can #18967 be reverted?

cc @zoracon @J0WI @jeremyn @pipboy96 @jayvdb

@J0WI J0WI added the amazon-s3-2020 Bare s3.amazonaws.com domain deprecation, see #17912 label Mar 10, 2020
@zoracon zoracon self-requested a review March 10, 2020 23:38
@zoracon
Copy link
Copy Markdown
Contributor

zoracon commented Mar 10, 2020

I thought my hotfix to master fixed this but looks like that was not the case. I will revert this and my subsequent PR and hope that clears up the issue.

@zoracon zoracon merged commit 0c75b04 into EFForg:master Mar 14, 2020
@cschanaj cschanaj deleted the mediapost-com branch March 14, 2020 02:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

amazon-s3-2020 Bare s3.amazonaws.com domain deprecation, see #17912 ruleset-enhancement top-10k

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants