This repository was archived by the owner on Nov 6, 2023. It is now read-only.
update Ecosia.xml subdomains, short URL#18995
Merged
J0WI merged 5 commits intoEFForg:masterfrom Mar 2, 2020
Merged
Conversation
csavard-sudo
changed the title
J0WI
reviewed
Mar 1, 2020
Contributor
J0WI
left a comment
J0WI
left a comment
There was a problem hiding this comment.
Please add more test urls to ensure that the wildcard does not break anything. https://github.com/EFForg/https-everywhere/blob/master/CONTRIBUTING.md#left-wildcards
Contributor
Author
@J0WI done - I included ample test urls in the latest commit, particularly from important subdomains such as the cdn and blog. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added wildcard to include subdomains and added "ecosia.co" shortlink as it is used periodically on their site.