This repository was archived by the owner on Nov 6, 2023. It is now read-only.
https_everywhere_checker syntax fixes#18987
Merged
zoracon merged 2 commits intoEFForg:masterfrom Apr 15, 2020
Merged
Conversation
Contributor
Author
|
It looks like there are no unittests for the checker, neither here nor in the original repo. |
Contributor
Author
Contributor
|
Pulling this down today to test. |
zoracon
approved these changes
Apr 15, 2020
Contributor
zoracon
left a comment
zoracon
left a comment
There was a problem hiding this comment.
Tested locally yesterday and reviewed. I didn't see issues with these changes so will merge in for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List related issues if any