Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

AmazonAWS.com.xml: Remove failing test#18919

Merged
cschanaj merged 2 commits intoEFForg:masterfrom
jayvdb:lbrcdn
Feb 22, 2020
Merged

AmazonAWS.com.xml: Remove failing test#18919
cschanaj merged 2 commits intoEFForg:masterfrom
jayvdb:lbrcdn

Conversation

@jayvdb
Copy link
Copy Markdown
Contributor

@jayvdb jayvdb commented Feb 13, 2020

Hostname is now in Law_Business_Research_CDN.xml

Fixes #18918

@jayvdb jayvdb mentioned this pull request Feb 13, 2020
Merged
@jayvdb
AmazonAWS.com.xml: Remove failing test
61d5a74 
Hostname is now target in Law_Business_Research_CDN.xml

Fixes EFForg#18918
@jayvdb
Copy link
Copy Markdown
Contributor Author

jayvdb commented Feb 13, 2020 •
edited
Loading

I assume is it safe to also remove the exclusion from this rule.

The other approach would be to remove the target from Law_Business_Research_CDN.xml . For parsing that is a better approach, to avoid domains being split across multiple rulesets, but there are lots of other domains split across multiple rulesets so I guess that goal isnt desirable/achievable.

@cschanaj
Copy link
Copy Markdown
Collaborator

cschanaj commented Feb 13, 2020

The other approach would be to remove the target from Law_Business_Research_CDN.xml

As you might note that Law_Business_Research_CDN.xml is not updated since 2014. There is some recent efforts to avoid merging multiple domain targets in the same ruleset. So I would recommend you to do it the other way.

Besides, the rewrites in Law_Business_Research_CDN.xml will fail in September 2020 (#17912). It would be great if you could remove it in the PR as well.

@cschanaj cschanaj self-assigned this Feb 13, 2020
cschanaj
cschanaj suggested changes Feb 20, 2020
View reviewed changes
@jayvdb
Delete Law_Business_Research_CDN.xml
81fcf0e 
It will be non-functional due to AWS changes.

Related to EFForg#17912
@cschanaj cschanaj merged commit c4c50fc into EFForg:master Feb 22, 2020
@cschanaj
Copy link
Copy Markdown
Collaborator

cschanaj commented Feb 22, 2020

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@cschanaj cschanaj cschanaj requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cschanaj cschanaj

Labels

ruleset-enhancement top-100

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AmazonAWS.com.xml failing test overlaps with Law_Business_Research_CDN.xml

4 participants

@jayvdb @cschanaj @zoracon @pipboy96