This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Greek-travel.xml: Remove outdated tests and rules#18900
Merged
zoracon merged 4 commits intoEFForg:masterfrom Oct 15, 2020
Merged
Greek-travel.xml: Remove outdated tests and rules#18900zoracon merged 4 commits intoEFForg:masterfrom
zoracon merged 4 commits intoEFForg:masterfrom
Conversation
Contributor
|
If possible, please split this PR into 3 separate PRs, one for each file. |
Contributor
Author
|
Moved change which passes CI to #18919 Now looking at CI results for the other two. |
jayvdb
force-pushed
the
misc-test-data-mismatches
branch
from
1f80a8f to
32703c2
Compare
jayvdb
force-pushed
the
misc-test-data-mismatches
branch
from
2bb81e4 to
16871de
Compare
Contributor
Author
|
(Rebased and added "Update ruleset-whitelist.csv" commit; no other changes) |
Contributor
Author
|
https://travis-ci.org/EFForg/https-everywhere/jobs/660131809
Again I cant reproduce this locally. It is the only error. |
jayvdb
force-pushed
the
misc-test-data-mismatches
branch
from
f3c66e4 to
2ad01c4
Compare
These exclusions cause the checker to report insufficient tests, and also appear unnecessary now.
jayvdb
force-pushed
the
misc-test-data-mismatches
branch
from
2ad01c4 to
8ae902f
Compare
Contributor
Author
|
ping @zoracon . Not sure why you marked this invalid. |
Contributor
|
@jayvdb I see no issues with this PR. |
pipboy96
approved these changes
Oct 10, 2020
pipboy96
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18893
Note: I am not 100% confident that these fixes are the most appropriate way to solve the problems.