Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Remove rulesets from coverage whitelist if they pass the coverage test#18066

Closed
pipboy96 wants to merge 2 commits intoEFForg:masterfrom
pipboy96:coverage-fix
Closed

Remove rulesets from coverage whitelist if they pass the coverage test#18066
pipboy96 wants to merge 2 commits intoEFForg:masterfrom
pipboy96:coverage-fix

Conversation

@pipboy96
Copy link
Copy Markdown
Contributor

@pipboy96 pipboy96 commented Jun 6, 2019

Feel free to cherry-pick the first commit and run ruleset-whitelist-cleanup.sh separately.

@pipboy96 pipboy96 requested review from Hainish, J0WI and cschanaj June 6, 2019 22:41
@Hainish
Copy link
Copy Markdown
Member

Hainish commented Jun 7, 2019

This seems to have changed the ordering of some lines without changing anything else. The previous ordering was sorted with https://github.com/EFForg/https-everywhere/blob/master/utils/ruleset-whitelist-cleanup.sh#L41

@cschanaj cschanaj mentioned this pull request Jun 7, 2019
Merged
@pipboy96
Copy link
Copy Markdown
Contributor Author

pipboy96 commented Jun 7, 2019 •
edited
Loading

@Hainish I have noticed that. Seems this script has somehow lost its case insensitivity. It did remove some rulesets, see diff for caca02f.

@pipboy96 pipboy96 added the hold label Jun 7, 2019
@pipboy96 pipboy96 closed this Jun 7, 2019
@pipboy96 pipboy96 deleted the coverage-fix branch August 7, 2019 20:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@J0WI J0WI Awaiting requested review from J0WI

@cschanaj cschanaj Awaiting requested review from cschanaj

@Hainish Hainish Awaiting requested review from Hainish

Assignees

No one assigned

Labels

hold toolchain

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pipboy96 @Hainish