This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Update schema.xml#17910
Merged
Hainish merged 1 commit intoEFForg:masterfrom Jun 6, 2019
pipboy96:schema
Merged
Conversation
Collaborator
|
What's the reasoning behind disallowing non-ASCII characters? Are they causing any issue? |
Contributor
Author
|
The last target that wasn't converted to Punycode was fixed. Also, I believe any target with these characters would be no-op, since HTTPS Everywhere doesn't decode Punycode. |
Collaborator
It seems that they are in fact no-op 🤔 URL passed to the extensions are Punycoded. However, we perform trivial string comparison to the passed value, this will not work as expected. thus it is an no-op. |
Bisaloo
approved these changes
May 7, 2019
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #17909.