This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Add patch for Chrome run time issue#17490
Closed
zoracon wants to merge 2 commits intoEFForg:masterfrom
Closed
Conversation
Contributor
Author
|
Looks like I now botched the Firefox flow with this change, gonna look into the test itself more to see how to improve on it |
pipboy96
reviewed
Oct 2, 2019
Contributor
Author
|
This has been resolved through amending the selenium test, closing this out |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caught that at times "item" is not defined during "show counter" test. Causing Chrome and Chrome Beta test to fail. Adding this in as a stop gap so this test can continue for future PRs.
Related: #17274