This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Disable "Show Counter" test (temporarily) for Chrome#17274
Merged
zoracon merged 2 commits intoEFForg:masterfrom Jan 31, 2019
Merged
Disable "Show Counter" test (temporarily) for Chrome#17274zoracon merged 2 commits intoEFForg:masterfrom
zoracon merged 2 commits intoEFForg:masterfrom
Conversation
- Show counter has been failing lately for many PRs - Suspected cause: deprecation warning - Pushing fix for deprecation
Contributor
Author
|
Pulling an Apple and skipping test for now with Chrome, while working on a solution for fixing this. |
zoracon
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Message
(Warnings.warn('use options instead of chrome_options', DeprecationWarning))
Edit: Checks out to not be the issue, will investigate further for a solution
Going to skip the test for now in Chrome. If not hashed out by Release time I will merge for the sake of people's PRs