Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Change HTTP Block language#17156

Merged
zoracon merged 7 commits intoEFForg:masterfrom
zoracon:change-http-block-language
Jan 8, 2019
Merged

Change HTTP Block language#17156
zoracon merged 7 commits intoEFForg:masterfrom
zoracon:change-http-block-language

Conversation

@zoracon
Copy link
Copy Markdown
Contributor

@zoracon zoracon commented Dec 18, 2018

- For better user clarity for when they request unencrypted requests
@zoracon zoracon requested a review from Hainish December 18, 2018 22:13
@Hainish
Copy link
Copy Markdown
Member

Hainish commented Dec 19, 2018

This will make it so that previous translations of "Block all unecrypted requests" will now be the translation for "Encrypt All Sites Eligible." Is this the desired behavior?

We may want to change the localization string variable name too, since this will clear the existing translations for this variable. Then again, since doing a release tomorrow, that will leave very little time and probably all non-English languages will have this string untranslated for the next release. Maybe immediately after release, we can switch the underlying variable name. That'll give us a lot of runway for that to be translated properly.

<!ENTITY https-everywhere.menu.observatory "SSL Observatory Preferences">
<!ENTITY https-everywhere.menu.globalEnable "Enable HTTPS Everywhere">
<!ENTITY https-everywhere.menu.blockUnencryptedRequests "Block all unencrypted requests">
<!ENTITY https-everywhere.menu.blockUnencryptedRequests "Encrypt All Sites Eligible">
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might also add " (EASE)" to this, to make it easy (no pun intended) to refer to.

@J0WI J0WI added the ui label Dec 21, 2018
@zoracon
Copy link
Copy Markdown
Contributor Author

zoracon commented Jan 3, 2019

This will make it so that previous translations of "Block all unecrypted requests" will now be the translation for "Encrypt All Sites Eligible." Is this the desired behavior?

We may want to change the localization string variable name too, since this will clear the existing translations for this variable. Then again, since doing a release tomorrow, that will leave very little time and probably all non-English languages will have this string untranslated for the next release. Maybe immediately after release, we can switch the underlying variable name. That'll give us a lot of runway for that to be translated properly.

I can go ahead and change that variable name. As far as the translation issue, should I change the language just in the frontend to avoid problems? Is there a way to send a directive to help "re-translate" this line I can send out prior to merging in?

@zoracon zoracon merged commit 27ec9b5 into EFForg:master Jan 8, 2019
@zoracon zoracon deleted the change-http-block-language branch January 8, 2019 22:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants