Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Disable thinkprogress and zillow. #1354

Merged
cooperq merged 1 commit into from
Apr 6, 2015
Merged

Disable thinkprogress and zillow. #1354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,5 @@
lxml>=3.3.3
pycurl
regex
bsdiff4
python-Levenshtein
14 changes: 3 additions & 11 deletions ruleset-testing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,18 +57,10 @@ will break the build. This means that even fixes of existing rules may require
additional work to bring them up to snuff.

To run the tests locally, you'll need the https-everywhere-checker, which is now
a submodule of https-everywhere. Run these commands to set it up:
a submodule of https-everywhere. To set it up, run:

git submodule init
git submodule update
cd https-everywhere-checker
pip install --user -r requirements.txt
cd -
./test-ruleset-coverage.sh

Note you may also need to apt-get install libcurl4-openssl-dev so that one of
the requirements in https-everywhere-checker can be satisfied.
./install-dev-dependencies.sh

To test a specific ruleset:

python2.7 https-everywhere-checker/src/https_everywhere_checker/check_rules.py https-everywhere-checker/checker.config.sample rules/Example.xml
./fetch-test.sh rules/Example.xml
2 changes: 1 addition & 1 deletion src/chrome/content/rules/Center-for-American-Progress.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
¹ Secured by us

-->
<ruleset name="Center for American Progress (partial)">
<ruleset name="Center for American Progress (partial)" default_off="breaks site">

<target host="thinkprogress.org"/>
<target host="www.thinkprogress.org"/>
Expand Down
5 changes: 4 additions & 1 deletion src/chrome/content/rules/Zillow.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
<!--
Disbaled because it breaks overlay on pages like http://www.zillow.com/homes/for_sale/San-Francisco-CA/San-Francisco-CA_rb/
See https://github.com/EFForg/https-everywhere/issues/1353

For problematic rules, see Zillow-problematic.xml


Expand Down Expand Up @@ -63,7 +66,7 @@
* Secured by us, doesn't trip MCB anyway

-->
<ruleset name="Zillow (partial)">
<ruleset name="Zillow (partial)" default_off="Breaks overlays">

<target host="zillow.com" />
<target host="*.zillow.com" />
Expand Down