Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

add rules for lebsanft.org#1319

Merged
reedy merged 8 commits intoEFForg:masterfrom
piratenpanda:master
Jun 16, 2015
Merged

add rules for lebsanft.org#1319
reedy merged 8 commits intoEFForg:masterfrom
piratenpanda:master

Conversation

@piratenpanda
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should just use the updated/simplified rule format here

<rule from="^http:" to="https:" />

You could then just explicitly only target www and no subdomain, and remove the exclusion. Simplies the ruleset somewhat

@piratenpanda
Copy link
Copy Markdown
Contributor Author

Hopefully this is how it should be

@reedy
Copy link
Copy Markdown
Contributor

reedy commented Apr 16, 2015

I wouldn't have deleted the test urls, nor the secure cookie probably (unless it's unused?).

This ruleset now doesn't secure http://lebsanft.org/ either - is this intended?

@piratenpanda
Copy link
Copy Markdown
Contributor Author

Oops let me fix that

@piratenpanda
Copy link
Copy Markdown
Contributor Author

Do I need a rule when the folder without www is just a symlink to www. Will this work for https-everywhere just fine? If yes, then I can just omit it.

@reedy
Copy link
Copy Markdown
Contributor

reedy commented Apr 17, 2015

The server adds the www with a 301, so that's fine

chronos@localhost / $ curl -I http://lebsanft.org
HTTP/1.1 301 Moved Permanently
Date: Fri, 17 Apr 2015 13:33:32 GMT
Server: Apache/2.2.15 (CentOS)
X-Powered-By: PHP/5.4.4
X-Pingback: http://www.lebsanft.org/xmlrpc.php
Location: http://www.lebsanft.org/
Connection: close
Content-Type: text/html; charset=UTF-8

chronos@localhost / $

@piratenpanda
Copy link
Copy Markdown
Contributor Author

then I guess this can be merged

reedy added a commit that referenced this pull request Jun 16, 2015
@reedy reedy merged commit 485133b into EFForg:master Jun 16, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants