Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Indymedia.xml: Implicit target prefix globs #18893

@jayvdb

Description

@jayvdb

Type: code issue

It appears that enabled rulesets Indymedia.org (partial) and Greek-travel (and maybe others not enabled or not platform=default) have tests which are broken due to being left behind when targets were removed.

If they are passing in this repo, then they appear to rely on unspecified target prefix globs, which I hope isnt required to implement https-everywhere for reasons similar to #18892

e.g. Indymedia.xml contains only <target host="belgium.indymedia.org" /> without any *. prefix but a rule with from ^http://www\.belgium\.indymedia\.org/. 429ba1b appears to have created this problem.

In Greek-travel.xml, there is a test for http://es.about.aegeanair.com/Css/fonts/Roboto-Bold/Roboto-Bold.ttf, but the host es.about.aegeanair.com is not in targets. Likewise for test http://ru.about.aegeanair.com/Css/fonts/Roboto-Bold/Roboto-Bold.ttf. It looks like this was an update problem, as there are commented out exclusions would seem relevant.

Another one I encountered is ruleset 'AmazonWebServices' (AmazonAWS.com.xml), and test http://s3.lbrcdn.net.s3-external-3.amazonaws.com/, which fails because it matches rules now in ruleset Law_Business_Research_CDN.xml.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions