This repository was archived by the owner on Jan 14, 2018. It is now read-only.
Fix bug where animated argument was ignored #397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anchorTopViewTo*Animated: and resetTopViewAnimated: is ignoring the animated argument. In practice is not the ECSlidingViewController but rather the ECSlidingAnimationController (default implementation). Apple also recommends to check the isAnimated property of the UIViewControllerContextTransitioning delegate. Fix bug ECSlidingViewController#327 Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
anchorTopViewTo*Animated: and resetTopViewAnimated: is ignoring the animated argument. In practice is not the ECSlidingViewController but rather the ECSlidingAnimationController (default implementation).
Apple also recommends to check the isAnimated property of the UIViewControllerContextTransitioning delegate.
Fix bug #327
Signed-off-by: Felipe F. Tonello eu@felipetonello.com