Skip to content

Add dump signal for DrCov#1956

Open
zofer1 wants to merge 4 commits into
DynamoRIO:masterfrom
zofer1:zofer1-patch-1-add_dump-signal
Open

Add dump signal for DrCov#1956
zofer1 wants to merge 4 commits into
DynamoRIO:masterfrom
zofer1:zofer1-patch-1-add_dump-signal

Conversation

@zofer1
Copy link
Copy Markdown

@zofer1 zofer1 commented Jun 20, 2016

Add the functionality to generate partial coverage report for daemon processes or processes that may core dump during shut down. Sending a signal to the process will dump the current collected data.

Linux only.

Possibly can be put to use for windows.

@derekbruening
Copy link
Copy Markdown
Contributor

Thank you for the contribution. However, drcov already has support for a daemon process killed by its parent using drx_register_soft_kills(), and to extend that to a human-sent signal we would want to use the same underlying mechanism, DR's nudge, which is cross-platform.

@derekbruening
Copy link
Copy Markdown
Contributor

Meant to add: we'd want the nudge handler to be extended, and the docs updated to talk about how to send the nudge.

@derekbruening
Copy link
Copy Markdown
Contributor

Please also see https://github.com/DynamoRIO/dynamorio/wiki/Contributing: if the CLA was signed under a different name please let us know. I don't see your github username.

@zofer1
Copy link
Copy Markdown
Author

zofer1 commented Jun 21, 2016

No I did not sign this. I found the tool usefull for a POC and decided to
add some functionality. Because I am doing so as part of my day-to-day work
I will need to run this through the legal department. Anyways, as you have
suggested an alternative way for doing so (the nudge) this is now
meaningless. How about you send me the details of this mechanism if this is
already active or point me in the right direction. If I make code changes
to put this to work, we will find the way to submit the changes.

Cheers, and keep up the good work.

On Mon, Jun 20, 2016 at 5:39 PM, derekbruening notifications@github.com
wrote:

Please also see https://github.com/DynamoRIO/dynamorio/wiki/Contributing:
if the CLA was signed under a different name please let us know. I don't
see your github username.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#1956 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AGnCA5ifGztu9TohPg2Rdk3US41fVEYlks5qNqYigaJpZM4I5i3e
.

@derekbruening
Copy link
Copy Markdown
Contributor

Not sure what else to add: search for nudge in drcov.c to find the relevant functions and look at the aforementioned drx_register_soft_kills() docs and search for nudge in the DR docs: http://dynamorio.org/docs/using.html#sec_comm

@derekbruening
Copy link
Copy Markdown
Contributor

Note that we no longer need the CLA to be signed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants